Bug 922340

Summary: Deadlock in org.jboss.as.ejb3.remote.protocol.versionone.MethodInvocationMessageHandler
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: wfink
Component: EJBAssignee: wfink
Status: CLOSED CURRENTRELEASE QA Contact: Jan Martiska <jmartisk>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.0.1CC: jawilson, rsvoboda, tgandotr
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
PATCH NAME: bz-922340 PRODUCT NAME: JBoss EAP VERSION: 6.0.1.GA SHORT DESCRIPTION: EAP 6.0.1 - Backport of AS7-6086 LONG DESCRIPTION: Due to an uncatched Exception the server hung https://issues.jboss.org/browse/AS7-6086 MANUAL INSTALL INSTRUCTIONS: Backup and remove the following files: $JBOSS_HOME/modules/org/jboss/as/ejb3/main/jboss-as-ejb3-7.1.3.Final-redhat-4.jar $JBOSS_HOME/modules/org/jboss/as/ejb3/main/module.xml Extract the patched files by either: Using unzip: unzip -d $JBOSS_HOME/ bz-922340.zip Or by extracting the files from the zip to the following locations: $JBOSS_HOME/modules/org/jboss/as/ejb3/main/jboss-as-ejb3-7.1.3.Final-redhat-4-bz-922340.jar $JBOSS_HOME/modules/org/jboss/as/ejb3/main/module.xml Instructions to uninstall: Restore the following files that were backed up before the patch was installed: $JBOSS_HOME/modules/org/jboss/as/ejb3/main/jboss-as-ejb3-7.1.3.Final-redhat-4.jar $JBOSS_HOME/modules/org/jboss/as/ejb3/main/module.xml COMPATIBILITY: None DEPENDENCIES: JBoss EAP 6.0.1.GA SUPERSEDES: None SUPERSEDED BY: JBoss EAP 6.1.0 CREATOR: Wolf-Dieter Fink DATE: 16 March 2013
Story Points: ---
Clone Of: 922339 Environment:
Last Closed: 2013-04-02 13:20:44 UTC Type: Support Patch
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 922339    
Bug Blocks:    
Attachments:
Description Flags
Prepared OneOff patch
none
Prepared OneOff patch (without sources)
none
Prepared OneOff patch (without sources) none

Description wfink 2013-03-16 10:28:26 UTC
+++ This bug was initially created as a clone of Bug #922339 +++

Created attachment 711015 [details]
Maven project to reproduce the issue

Description of problem:

The MethodInvocationMessageHandler doesn't catch java.lang.IllegalArgumentException.
This causes the server hangs.

How reproducible:
A simple reproducer based on the ejb-remote quickstart is attached


Steps to Reproduce:
1. compile and deploy the project (mvn clean install jboss-as:deploy)
2. run the client 
   java -cp target/classes:../server-side/target/jboss-as-ejb-remote-app-client.jar:../../jboss/bin/client/jboss-client.jar org.jboss.as.quickstarts.ejb.remote.client.RemoteEJBClient

Actual results:
Client hung

Expected results:
Exception at client side that the marshalling failed

--- Additional comment from  on 2013-03-16 06:23:55 EDT ---

Problem is solved in EAP6.1.Alpha

Comment 1 wfink 2013-03-16 10:48:00 UTC
Created attachment 711016 [details]
Prepared OneOff patch

Comment 2 Jan Martiska 2013-03-25 09:18:10 UTC
Hi Wolf, 
in the attached zip, I found a source jar for ejb3 module: modules/org/jboss/as/ejb3/main/jboss-as-ejb3-7.1.3.Final-redhat-4-sources-bz-922340.jar

I am not sure why this file is included, and the install instructions don't mention it. Is there any particular reason to include this file? If not, please attach a zip without it.. Then push this back to ON_QA.
Thanks

Comment 4 Jan Martiska 2013-03-25 10:13:32 UTC
Actually I don't remember seeing a source jar in the patch zip anytime in the past, that's why I am somewhat surprised. But if it conforms to GSS's rules, I have no objection, it doesn't do any harm, I just think it would be worth adding a note in the patch instructions, so the customer will see that the sources are included..

Comment 5 Jimmy Wilson 2013-03-25 13:40:16 UTC
It's not supposed to be in the patch overlay zip, but we do sometimes attach the sources to the BZ/JIRA in case there are customer questions later.  Certainly we can deliver the source JAR to customers as needed via the case, but we don't generally do that on the portal.

Comment 6 wfink 2013-03-25 17:40:13 UTC
Created attachment 716109 [details]
Prepared OneOff patch (without sources)

Comment 7 wfink 2013-03-25 17:42:40 UTC
Created attachment 716110 [details]
Prepared OneOff patch (without sources)

Comment 9 Jan Martiska 2013-03-27 07:34:32 UTC
reproduced manually: OK
regression testing: OK
checked that the fixed code is present in the source jar: OK

md5sum of patch files:
e4d2dfecf160cfb828541b73de964e41  ./modules/org/jboss/as/ejb3/main/jboss-as-ejb3-7.1.3.Final-redhat-4-bz-922340.jar
74fdb27b0f93564054f35c02bd063f77  ./modules/org/jboss/as/ejb3/main/module.xml

md5sum of additional source jar:
aa6cd8acb6628ba64f7a8697a3499faf  jboss-as-ejb3-7.1.3.Final-redhat-4-sources-bz-922340.jar

Comment 10 Tushar Gandotra 2013-04-02 13:20:44 UTC
This patch is applicable to JBoss Enterprise Application Platform (EAP) 6.0.1. It is available for download
from the following location:
https://access.redhat.com/jbossnetwork/restricted/softwareDetail.html?softwareId=20843