Bug 922447
| Summary: | bitlbee crashes on disconnection due to a memory problem | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Dewaleyne <fdewaley> |
| Component: | bitlbee | Assignee: | Robert Scheck <redhat-bugzilla> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 18 | CC: | aron, kevin, lmacken, mcepl, mcepl, pp, redhat-bugzilla |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | bitlbee-3.2-6.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-12 22:28:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
The problem is that conn->hostname is strdup'd in one code path but not another. I'll attach the patch. See also http://bugs.bitlbee.org/bitlbee/ticket/1038 Created attachment 713833 [details]
Fix bitlbee crash disconnecting SSL
*** Bug 918816 has been marked as a duplicate of this bug. *** Did somebody already have the chance to play with that patch? Seems to work (connect msn & fb jabber and then account off) + patch looks correct. I'll let it run (it randomly crashed previously every few hours-days and occasionally failed to connect at all) and let you know if it still fails, but +1 for a build with this fix. Works for me and patch pushed to the master branch. Unfortunately, koji is broken ATM, so I cannot provide a scratch build. Created attachment 730821 [details]
result of the valgrind --tool=memcheck --leak-check=yes
Matěj, checking leaks seems orthoganol to this ticket... Something to fix, sure, but shouldn't block fixing the crash? (In reply to comment #8) > Matěj, checking leaks seems orthoganol to this ticket... Something to fix, > sure, but shouldn't block fixing the crash? This crash is the result of double-free(http://en.wikipedia.org/wiki/Double_free#Common_errors), so memory management is very much on spot for checking we haven't overlooked anything else. Reporter, could you please check that the package from http://koji.fedoraproject.org/koji/taskinfo?taskID=5199260 (that's for Fedora 18) fixes the problem? +1 from here (no issues with self-compiled version since previous comment + quick test with koji build handled account off just fine). +1 from me too, the problem seems solved with the koji packages. bitlbee-3.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/bitlbee-3.2-3.fc17 bitlbee-3.2-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/bitlbee-3.2-3.fc18 bitlbee-3.2-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/bitlbee-3.2-3.fc19 bitlbee-3.2-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/bitlbee-3.2-3.el5 bitlbee-3.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bitlbee-3.2-3.el6 Package bitlbee-3.2-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing bitlbee-3.2-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-4759/bitlbee-3.2-3.fc19 then log in and leave karma (feedback). bitlbee-3.2-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-3.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 951867 has been marked as a duplicate of this bug. *** bitlbee-3.2-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/bitlbee-3.2-6.fc19 bitlbee-3.2-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/bitlbee-3.2-6.fc18 bitlbee-3.2-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bitlbee-3.2-6.el6 bitlbee-3.2-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/bitlbee-3.2-6.el5 bitlbee-3.2-6.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-6.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-6.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. bitlbee-3.2-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 711228 [details] screen output generated with gdb --batch -ex run -ex bt --args /usr/sbin/bitlbee -Dnvc /etc/bitlbee/bitlbee.conf Description of problem: when closing an open connection or disconnecting from bitlbee, the output is generated. Version-Release number of selected component (if applicable): bitlbee.x86_64 3.2-1.fc18 @updates bitlbee-debuginfo.x86_64 3.2-1.fc18 @updates-debuginfo bitlbee-devel.x86_64 3.2-1.fc18 @updates bitlbee-otr.x86_64 3.2-1.fc18 @updates How reproducible: all the time Steps to Reproduce: 1. configure a jabber account using gtalk 2. start bitlbee, connect as usual 3. issue account gtalk off or disconnect Actual results: *** glibc detected *** /usr/sbin/bitlbee: munmap_chunk(): invalid pointer: 0x0000555555814f21 *** Expected results: bitlbee does not crash Additional info: script output of gdb --batch -ex run -ex bt --args /usr/sbin/bitlbee -Dnvc /etc/bitlbee/bitlbee.conf I am able to reproduce this with just gtalk but in the test may have had also the aim and yahoo plugins enabled. I was tracking another bug when I noticed this one.