Bug 922683
Summary: | Guest with iso fail to migrate when the iso's domain is inactived | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Luwen Su <lsu> | ||||
Component: | libvirt | Assignee: | Jiri Denemark <jdenemar> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Virtualization Bugs <virt-bugs> | ||||
Severity: | urgent | Docs Contact: | |||||
Priority: | urgent | ||||||
Version: | 6.4 | CC: | acathrow, cpelland, dyasny, dyuan, jdenemar, mjenner, mzhan, rwu, whuang, zhwang | ||||
Target Milestone: | rc | Keywords: | Regression | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2013-03-18 14:54:09 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Comment 1
zhenfeng wang
2013-03-18 10:29:55 UTC
Could you attach the domain XML used by vdsm when starting the domain? Created attachment 711887 [details]
vdsm guest xml when start
Hi, Jiri
I have a guest ,it also can reproduce this issue
I attach it xml for you
The regression is caused by commit 82d5fe543720da6d83c1d6bfa1c347d7d9fda278 Author: Eric Blake <eblake> Date: Wed Feb 20 15:34:48 2013 -0700 qemu: check backing chains even when cgroup is omitted https://bugzilla.redhat.com/show_bug.cgi?id=896685 points out a regression caused by commit 38c4a9c - libvirt only labels the backing chain if the backing chain cache is populated, but the code to populate the cache was only conditionally performed if cgroup labeling was necessary. * src/qemu/qemu_cgroup.c (qemuSetupCgroup): Hoist cache setup... * src/qemu/qemu_process.c (qemuProcessStart): ...earlier into caller, where it is now unconditional. Fix proposed upstream: https://www.redhat.com/archives/libvir-list/2013-March/msg01018.html Fixed upstream by v1.0.3-88-gef3cd64: commit ef3cd6473f5227fcc89ac4fd1fc4f8485ffae314 Author: Jiri Denemark <jdenemar> Date: Mon Mar 18 14:11:58 2013 +0100 qemu: Fix startupPolicy regression Commit 82d5fe543720da6d83c1d6bfa1c347d7d9fda278 qemu: check backing chains even when cgroup is omitted added backing file checks just before the code that removes optional disks if they are not present. However, the backing chain code fails in case the disk file does not exist, which makes qemuProcessStart fail regardless on configured startupPolicy. Note that startupPolicy implementation is still wrong after this patch since it only check the first file in a possible chain. It should rather check the complete backing chain. But this is an existing limitation that can be solved later. After all, startupPolicy is most useful for CDROM images and they won't make use of backing files in most cases. Actually, after thinking about this more and consulting with Jiri Pallich, it makes more sense to fix this regression in the context of the original BZ that pulls in patches which cause the regression. Thus, I'm closing this bug as a duplicate of the original bug 896013 and I'll make sure the fix is also pulled in for the z-stream clone. *** This bug has been marked as a duplicate of bug 896013 *** |