Bug 922689
| Summary: | No error message shown when user tried to add non-supported cartridges to app via website. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | OKD | Reporter: | Mengjiao Gao <mgao> | ||||
| Component: | Website | Assignee: | Fotios Lindiakos <fotios> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 2.x | CC: | ccoleman, dmcphers, jkeck, szhou, xtian, yujzhang | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-04-02 13:46:16 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
High severity because it's a regression - we may end up needing to hotfix this, but don't create a stage branch yet. Looks like it's related to the duplicate errors changes. (In reply to comment #1) > High severity because it's a regression - we may end up needing to hotfix > this, but don't create a stage branch yet. Looks like it's related to the > duplicate errors changes. As far as I know this bug can not be reproduced on STG,( it works as expected in current STG), it only happens on devenv, so maybe no hot fix is needed. Submitted a PR for this: https://github.com/openshift/origin-server/pull/1813 We were suppressing the cartridge error messages, but since this didn't actually have an input associated with it, we never saw the inline errors. Commit pushed to master at https://github.com/openshift/origin-server https://github.com/openshift/origin-server/commit/fd23cee28caa2ba58474e17b90a2db345c9b45e8 Merge pull request #1813 from fotioslindiakos/BZ922689 Bug 922689: Fix for not showing proper cartridge errors Tested on devenv_3002, created an php application, tried to add jenkins client without jenkins server, and tried to add switchyard to php application , both will get error message to remind, thanks, verify this bug. |
Created attachment 711851 [details] development.log from /var/log/openshift/site/ Description of problem: When adding non-supported cartridge to apps via website,(such like: adding cartridge jenkins-client to apps without jenkins server created, or adding switchyard to non-jboss app, or adding phpmyadmin, rockmongo, cron to scalable apps) , cartridges should not be added successfully, and user should see the error message. But on devenv_2957, no error message cannot be shown in the cartridge adding page. Version-Release number of selected component (if applicable): devenv_2957 How reproducible: always Steps to Reproduce: 1.Go to website and login with a new user 2.Create a php application. 3.Try to add cartridge "switchyard" or "jenkins-client" to the app Actual results: At step 3, the cartridge "switchyard" or "jenkins-client" cannot be added to the app. When user tried to add these two cartridge, the cartridge adding page will always return to itself again.And no error message shown in the page. Expected results: User shoulded not add these two cartridges to the php app, but the error message should shown as:"Invalid cartridge. Jenkins server does not exist! Please create with rhc app create -t jenkins-1.4 ", or "Invalid cartridge. SwitchYard is only supported for JBoss AS/EAP ". Additional info: Have tried this issue on PROD and STG, not found the bug. And have tried this via CLI , error message will be shown correctly via CLI, as follows: ---------------------------------------------------------------------------- [root@dhcp-9-249 .openshift]# rhc cartridge add jenkins-client -a eap Password: ****** Adding 'jenkins-client-1.4' to application 'eap' Invalid cartridge. Jenkins server does not exist! Please create with rhc app create -t jenkins-1.4 ---------------------------------------------------------------------------- Will attached the development.log from /var/log/openshift/site/