Bug 922841

Summary: Review Request: perl-Text-ParseWords - Parse text into an array of tokens or array of arrays
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, psabata
Target Milestone: ---Flags: psabata: fedora-review+
pbabinca: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Text-ParseWords-3.29-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-03-20 10:46:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2013-03-18 16:27:32 UTC 
Spec URL: http://ppisar.fedorapeople.org/perl-Text-ParseWords/perl-Text-ParseWords.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Text-ParseWords/perl-Text-ParseWords-3.29-1.fc20.src.rpm
Description:
The nested_quotewords() and quotewords() functions accept a delimiter (which
can be a regular expression) and a list of lines and then breaks those lines
up into a list of words ignoring delimiters that appear inside quotes.
quotewords() returns all of the tokens in a single long list, while
nested_quotewords() returns a list of token lists corresponding to the
elements of @lines. parse_line() does tokenizing on a single string. The
quotewords() functions simply call &parse_line(), so if you're only splitting
one line you can call parse_line() directly and save a function call.

Fedora Account System Username: ppisar

----
This package will dual-live with perl core modules.
Comment 1 Petr Šabata 2013-03-19 14:34:36 UTC 
Hm, the only place where the license is mentioned is in Makefile.PL.  Perhaps a comment in the spec file mentioning it would be helpful for future maintainers and/or reviewers.

No real issues, approving.
Comment 2 Petr Pisar 2013-03-20 07:28:02 UTC 
New Package SCM Request
=======================
Package Name: perl-Text-ParseWords
Short Description: Parse text into an array of tokens or array of arrays
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig
Comment 3 Pavol Babinčák 2013-03-20 10:29:36 UTC 
Git done (by process-git-requests).
Comment 4 Petr Pisar 2013-03-20 10:46:00 UTC 
Thank you for the review and the repository.