Bug 923405

Summary:	thread dumps report the wrong log file name due to timezone
Product:	OKD	Reporter:	Luke Meyer <lmeyer>
Component:	Containers	Assignee:	Luke Meyer <lmeyer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	bmeng, chunchen, dmcphers, xtian, zhewang
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-02 13:41:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	921537

Description Luke Meyer 2013-03-19 18:43:07 UTC

Description of problem:
When doing a thread dump on an httpd-based app, during Daylight Saving Time the log file it says the dump should be in is different from the actual log file, due to difference in timezone. The threaddump API reports the file name from the node, and the client simply passes it on.

How reproducible:
Always (during DST)

Steps to Reproduce:
1. rhc app create bork ruby-1.8
2. Visit the app
3. rhc threaddump bork
4. Follow the command it suggests
  
Actual results:
3. The thread dump file will be available via: rhc tail bork -f ruby-1.8/logs/error_log-20130319-000000-EDT -o '-n 250'
4. Could not find any files matching glob
(The actual file name is error_log-20130319-000000-EST)

Expected results:
3. Should report a file name or glob that works.

Additional info:
As we discovered in bug 921537, what's actually happening is that rotatelogs produces log files with the wrong timezone. Regardless of that problem, having to match the exact file name without actually looking to see that it's there is fragile, and I'm suggesting we look to see the actual most recent log file that's there instead of trying to generate what it should be. Alternatively, report a glob rather than the exact file name.

Comment 1 openshift-github-bot 2013-03-20 14:28:15 UTC

Commits pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/e83866b1b1753bde0a47e33fb2a94e0eeb436e76
<threaddump> fix bug 923405 so ruby thread dump reports useful log file

https://bugzilla.redhat.com/show_bug.cgi?id=923405 thread dumps report the wrong log file name due to timezone

When ruby does a thread dump it goes in the httpd server log. This is
rotated via rotatelogs and the name includes the timezone in it. Due to
various complications this does not always match the TZ from `date`.
Rather than try to give the exact file name, we now just give a glob
that is good enough.

https://github.com/openshift/origin-server/commit/222fee1b460b75c1e14eb355a244458df068f88a
Merge pull request #1710 from sosiouxme/bz923405

<threaddump> fix bug 923405 so ruby thread dump reports useful log file

Comment 2 Zhe Wang 2013-03-22 10:24:08 UTC

Verified in INT(devenv_2984)

1. rhc app create bork ruby-1.9
2. Visit the app
3. rhc threaddump bork
4. Follow the command it suggests

Output:

[Fri Mar 22 06:22:12 2013] [notice] SELinux policy enabled; httpd running as context unconfined_u:system_r:openshift_t:s0:c2,c623
[Fri Mar 22 06:22:12 2013] [notice] mod_bw : Memory Allocated 32 bytes (each conf takes 32 bytes)
[Fri Mar 22 06:22:12 2013] [notice] mod_bw : Version 0.8 - Initialized [1 Confs]
[Fri Mar 22 06:22:12 2013] [notice] Digest: generating secret for digest authentication ...
[Fri Mar 22 06:22:12 2013] [notice] Digest: done
[Fri Mar 22 06:22:12 2013] [notice] Apache/2.2.15 (Unix) Phusion_Passenger/3.0.17 configured -- resuming normal operations