Bug 923460
| Summary: | Review Request: libqmi - glib helper library for the Qualcomm MSM Interface (QMI) protocol | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Williams <dcbw> | ||||
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | notting, package-review, yaneti | ||||
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-05-13 16:04:04 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Dan Williams
2013-03-19 22:01:58 UTC
*** Bug 914644 has been marked as a duplicate of this bug. *** Yanko: oops :) Didn't realize there was another request, sorry about that. Hey, can you post the docs patch you had again? I have no idea where it went, and I'm sure the pastebin expired. I'd like to apply it upstream since it's been reviewed and approved. Created attachment 744285 [details]
Always generate docs on dist time
Perhaps this was the one. At least that's whats git diff 'ing at the tree I have here.
Updated with Yanko's patches: Spec URL: http://people.redhat.com/dcbw/libqmi.spec SRPM URL: http://people.redhat.com/dcbw/libqmi-1.3.0-1.fc17.src.rpm Description: This package contains the libraries that make it easier to use QMI functionality from applications that use glib. Fedora Account System Username: dcbw The Source line needs an explanation or ideally a url for a new release, which would also help get rid of the ORIG-docs cruft.
There is also some legacy leftovers - BuildRoot, %define vs %global, %defattr, %{__rm} -rf $RPM_BUILD_ROOT
Updated again; I added a comment for the SOURCE line; there won't always be fixes, and it's much smoother to make dist a tarball from git than it is to git format-patch -X and add those all to the fedora package. Thus there isn't an upstream source URL from the tarball I've used. Spec URL: http://people.redhat.com/dcbw/libqmi.spec SRPM URL: http://people.redhat.com/dcbw/libqmi-1.3.0-1.git20130508.fc17.src.rpm Description: This package contains the libraries that make it easier to use QMI functionality from applications that use glib. Fedora Account System Username: dcbw wrt Source: I prefer the exact opposite approach, but given you'll be the maintainer there is little point in blocking on it. Looking at the source I think the main package license should be LGPLv2+ and only the -utils GPLv2+ Some minor issues: libqmi.x86_64: W: incoherent-version-in-changelog 1.2.0-1 ['1.3.0-1.git20130508.fc20', '1.3.0-1.git20130508'] libqmi.x86_64: E: zero-length /usr/share/doc/libqmi-1.3.0/README libqmi-devel.x86_64: E: zero-length /usr/share/doc/libqmi-devel-1.3.0/ChangeLog libqmi-devel.x86_64: W: summary-ended-with-dot C Header files for adding QMI support to applications that use glib. libqmi-utils.x86_64: W: summary-ended-with-dot C Utilities to use the QMI protocol from the command line. Builds in mock. Reasonably named and versioned. Does not conflict with anything existing. Please fix the license before importing. APPROVED Fixed all those errors, thanks! New Package SCM Request ======================= Package Name: libqmi Short Description: helper library for WWAN modems implement the QMI protocol Owners: dcbw Branches: f18 f19 Git done (by process-git-requests). Imported and built. Thanks everyone! |