Bug 923765

Summary:	Confusing and incompatible doc management for samba-dc and samba-dc-libs
Product:	[Fedora] Fedora	Reporter:	Nico Kadel-Garcia <nkadel>
Component:	samba	Assignee:	Guenther Deschner <gdeschner>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	19	CC:	abokovoy, asn, gdeschner, jlayton, sbose, ssorce
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-03-25 22:53:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nico Kadel-Garcia 2013-03-20 11:56:30 UTC

Description of problem:
   The attempt to stuff the README.dc and README.dc-libs for the samba-dc and samba-dc-libs packages into the /usr/share/doc/samba-4.0.3 from samba-common in the smaba.spec file fragile, non-porable, and confusing.

Version-Release number of selected component (if applicable):
   4.0.3

How reproducible:
   Review contents of samba-common-4.0.3, samba-dc-4.0.3, and samba-dc-libs-4.0.3.

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:
  Documentaiton for samba-dc-4.0.3 should be in /usr/share/doc/samba-dc-4.0.3 and for samba-dc-libs-4.0.3 in /usr/share/doc/samba-dc-libs-4.0.3.

Additional info:

Comment 1 Nico Kadel-Garcia 2013-03-20 12:12:17 UTC

This is trivial to fix: simply stop trying to stuff documentation directly into %{buildroot}/%{_defaultdocdir}/%{name}-%{versison} in the "%build phase" and install them to a working directory in the build environment. It's not compatible with older versons of rpm-build, and it's unnecessary. Instead, stage the files into the build directory as every other .spec file has done before the most recent versions of RPM.

In the '%build' section:
    install -d -m 0755 packaging/RHEL-rpms
    install -m 0644 %{SOURCE201} packaging/RHEL-rpms/README.downgrade

    install -m 0644 %{SOURCE200} packaging/RHEL-rpms/README.dc
    install -m 0644 %{SOURCE200} packaging/RHEL-rpms/README.dc-libs

In the "files" section:
    %doc packaging/RHEL-rpms/README.downgrade

And in the "%file dc" sction:
    %doc packaging/RHEL-rpms/README.dc

In the "%file dc-libs" section:
    %doc packaging/RHEL-rpms/README.dc-libs

Comment 2 Fedora Update System 2013-03-20 16:12:17 UTC

samba-4.0.4-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/samba-4.0.4-2.fc18

Comment 3 Fedora Update System 2013-03-21 23:58:29 UTC

Package samba-4.0.4-2.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing samba-4.0.4-2.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-4125/samba-4.0.4-2.fc18
then log in and leave karma (feedback).

Comment 4 Nico Kadel-Garcia 2013-03-22 02:03:20 UTC

Good stuff, but replacing "with_ntdb" with "with_internal_ntdb" was unnecessary and inappropriate. ntdb is an optional feature, not an externally buildable library, so the the label is once again confusing for that particular feature.

I should have specifically excluded that one.

Comment 5 Nico Kadel-Garcia 2013-03-22 03:10:00 UTC

Dang, sorry, that note was about the other bug I submitted. The README patches are great, thank you!

Comment 6 Fedora Update System 2013-03-22 10:11:39 UTC

samba-4.0.4-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/samba-4.0.4-3.fc18

Comment 7 Fedora Update System 2013-03-25 22:53:58 UTC

samba-4.0.4-3.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.