Bug 923831
| Summary: | Review Request: python-ipaddress - Port of the python 3.3+ ipaddress module to 2.6 and 2.7 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matt Domsch <matt_domsch> |
| Component: | Package Review | Assignee: | Sergio Pascual <sergio.pasra> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | matt_domsch, package-review, sergio.pasra, volker27 |
| Target Milestone: | --- | Flags: | sergio.pasra:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-24 13:14:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matt Domsch
2013-03-20 14:40:59 UTC
I'm unsure about the license being "Python". The header states: """ # Licensed to PSF under a Contributor Agreement. """ Looking at http://www.python.org/psf/contrib/contrib-form/, it seems like that doesn't clearly specify a license. Cosmetics: I suggest to use the version macro in Source0. Defining python_sitelib is no longer necessary. Neither is rm -rf $RPM_BUILD_ROOT in the install section. The files section could be slightly more specific. I think you should BR python2-devel. http://docs.python.org/dev/library/ipaddress >>> import ipaddress >>> ipaddress.ip_address('192.168.0.1') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python2.7/site-packages/ipaddress.py", line 105, in ip_address address) ValueError: '192.168.0.1' does not appear to be an IPv4 or IPv6 address (In reply to Volker Fröhlich from comment #3) > http://docs.python.org/dev/library/ipaddress > > >>> import ipaddress > >>> ipaddress.ip_address('192.168.0.1') > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > File "/usr/lib/python2.7/site-packages/ipaddress.py", line 105, in > ip_address > address) > ValueError: '192.168.0.1' does not appear to be an IPv4 or IPv6 address Try this instead >>> import ipaddress >>> ipaddress.ip_address(u'192.168.0.1') IPv4Address(u'192.168.0.1') the module expects unicode It seems that the upstream tarball is broken. The README file inside is missing (broken) link. There is no license information (notice that this code was originally under Apache License, e.g. https://code.google.com/p/ipaddress-py/source/browse/ipaddress.py) Could you ask upstream to make a new release and provide license information? Hi, are you still interested in this? Most of the problems (README, LICENSE) have been fixed upstream already I honestly have no recollection of building this package and why I would have done so. I expect I was looking at replacing IPy which is used in MirrorManager, and which is very lightly maintained, with a python 3.x standard library module for the same functionality. This package is the backport of that standard library module to python 2.6 and 2.7. Given we are now working on MirrorManger v2 (and by 'we', I mean various contributors) and meeting for FAD in Raleigh next week, I don't intend to maintain MM v1 anymore, thus my need for IPy goes away too. If someone else needs this, they're welcome to take it on. I'll close the review for now. Thank you Sergio and Volker for your effort here. |