Bug 923941

Summary:	Dependency generator can match incorrectly
Product:	[Fedora] Fedora	Reporter:	Tom Hughes <tom>
Component:	nodejs	Assignee:	T.C. Hollingsworth <tchollingsworth>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jamielinux, mrunge, sgallagh, tchollingsworth
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-05 23:02:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom Hughes 2013-03-20 18:39:24 UTC

The new native module dependency generator has this path match:

  %__nodejs_native_path ^/usr/lib.*/node_modules/.*\.node$

but it seems that it should actually be \\.node on the end - current it is matching any name (like jasmine-node) that happens to end in "node" and is adding false abi dependencies to those packages.

The original one is also wrong when matching package\.json but is rather less likely to actually mistrigger.

Comment 1 T.C. Hollingsworth 2013-03-20 20:22:58 UTC

jwz was wrong.  Regular expressions usually cause a lot more than *two* problems.  ;-)

I added the extra escape as you suggested and node-jasmine no longer seems to get the ABI provides.  Fixing the non-native one as suggested also doesn't seem to break anything, so we'll go with more correct even though I don't have a test case for breakage there.

nodejs-0.6.10-4 is building for all branches now.

Thanks for the report and the fix!

Comment 2 Fedora Update System 2013-03-20 21:00:35 UTC

v8-3.14.5.7-1.fc18, libuv-0.10.0-2.git5462dab.fc18, nodejs-0.10.0-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/FEDORA-2012-20578/nodejs-0.10.0-4.fc18,libuv-0.10.0-2.git5462dab.fc18,v8-3.14.5.7-1.fc18

Comment 3 Fedora Update System 2013-03-21 23:55:07 UTC

Package v8-3.14.5.7-1.fc18, libuv-0.10.0-2.git5462dab.fc18, nodejs-0.10.0-4.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing v8-3.14.5.7-1.fc18 libuv-0.10.0-2.git5462dab.fc18 nodejs-0.10.0-4.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-20578/nodejs-0.10.0-4.fc18,libuv-0.10.0-2.git5462dab.fc18,v8-3.14.5.7-1.fc18
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2013-03-22 20:59:32 UTC

Package libuv-0.10.0-2.git5462dab.fc18, nodejs-0.10.1-1.fc18, v8-3.14.5.8-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libuv-0.10.0-2.git5462dab.fc18 nodejs-0.10.1-1.fc18 v8-3.14.5.8-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-20578/nodejs-0.10.1-1.fc18,libuv-0.10.0-2.git5462dab.fc18,v8-3.14.5.8-1.fc18
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2013-04-03 04:54:18 UTC

Package v8-3.14.5.8-1.fc18, nodejs-0.10.2-1.fc18, libuv-0.10.3-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing v8-3.14.5.8-1.fc18 nodejs-0.10.2-1.fc18 libuv-0.10.3-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-20578/nodejs-0.10.2-1.fc18,libuv-0.10.3-1.fc18,v8-3.14.5.8-1.fc18
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2013-04-05 23:02:22 UTC

v8-3.14.5.8-1.fc18, nodejs-0.10.2-1.fc18, libuv-0.10.3-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.