Bug 924205

Summary: Wrong HTTP status code for the error pages
Product: [Community] Spacewalk Reporter: Martin Korbel <mkorbel>
Component: WebUIAssignee: Tomas Lestach <tlestach>
Status: CLOSED CURRENTRELEASE QA Contact: Red Hat Satellite QA List <satqe-list>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 1.10CC: tkasparek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 924196 Environment:
Last Closed: 2013-08-02 13:08:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 991452    

Description Martin Korbel 2013-03-21 11:06:45 UTC
+++ This bug was initially created as a clone of Bug #924196 +++

Description of problem:
When I open some URL, what makes error page (Page Request Error or Permission Error). I get HTTP status code 200, what means all is OK. 


Version-Release number of selected component (if applicable):
SpaceWalk 1.9, 1.10
Sat5.5.0
Sat5.4.1

How reproducible:
Page Request Error:
https://<satellite>/rhn/kickstart/KickstartPartitionEdit.do?ksid=

Permission Error:
Try it as no RHN Satellite Admin user.
https://<satellite>/rhn/admin/multiorg/OrgSystemSubscriptions.do?oid=1

  
Actual results:
I get the HTTP status code 200 on the page with Page Request Error or Permission Error.

Expected results:
I want to get the HTTP status code 403 on the page with Permission Error. 
I want to get the HTTP status code 400 on the page with Page Request Error.
 

Additional info:
http://en.wikipedia.org/wiki/List_of_HTTP_status_codes

Comment 1 Tomas Lestach 2013-05-06 15:50:04 UTC
return proper HTTP error codes like BAD_REQUEST, FORBIDDEN ...

spacewalk.git: a9c0890ef45ac9e7eed6df74880c8db299d260bc

Comment 2 Tomáš Kašpárek 2013-08-02 13:08:21 UTC
Fix for this bug is present in Spacewalk 2.0, closing this bug as CURRENTRELEASE.