Bug 924215

Summary:	glusterd crashes when rdma.so not present
Product:	[Community] GlusterFS	Reporter:	Rajesh <rajesh>
Component:	rpc	Assignee:	Vivek Agarwal <vagarwal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	gluster-bugs, jdarcy, sankarshan, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-24 17:54:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	918917

Description Rajesh 2013-03-21 11:19:49 UTC

Description of problem: glusterd crashes if the machine has no libibverbs/rdma.so


Version-Release number of selected component (if applicable): mainline

How reproducible: always


Steps to Reproduce:
1. Build and install glusterfs from source on a freshly installed machine (Bug found in RHS)
2. Start glusterd with just the command
  
Actual results: glusterd crashes


Expected results: shouldn't


Additional info: bt:
Core was generated by `glusterd'.
Program terminated with signal 11, Segmentation fault.
#0  0x00007f363228ebcf in list_del_init (old=0x0) at ../../../libglusterfs/src/list.h:62
62		old->prev->next = old->next;
(gdb) bt
#0  0x00007f363228ebcf in list_del_init (old=0x0) at ../../../libglusterfs/src/list.h:62
#1  0x00007f363228fa42 in rpc_transport_load (ctx=0xcb3010, options=0x7f3630c9f02c, trans_name=0xcdfc90 "rdma.management") at rpc-transport.c:342
#2  0x00007f363228c80a in rpcsvc_transport_create (svc=0xcd42e0, options=0x7f3630c9f02c, name=0xcdfc90 "rdma.management") at rpcsvc.c:1385
#3  0x00007f363228ca1f in rpcsvc_create_listener (svc=0xcd42e0, options=0x7f3630c9f02c, name=0xcdfc90 "rdma.management") at rpcsvc.c:1452
#4  0x00007f363228cc90 in rpcsvc_create_listeners (svc=0xcd42e0, options=0x7f3630c9f02c, name=0xcd8e20 "management") at rpcsvc.c:1531
#5  0x00007f362ea02bcf in init (this=0xcd8480) at glusterd.c:1050
#6  0x00007f36324b6de1 in __xlator_init (xl=0xcd8480) at xlator.c:380
#7  0x00007f36324b6ec8 in xlator_init (xl=0xcd8480) at xlator.c:403
#8  0x00007f36324f226a in glusterfs_graph_init (graph=0xcd4140) at graph.c:289
#9  0x00007f36324f28de in glusterfs_graph_activate (graph=0xcd4140, ctx=0xcb3010) at graph.c:477
#10 0x00000000004080a0 in glusterfs_process_volfp (ctx=0xcb3010, fp=0xcd3f00) at glusterfsd.c:1761
#11 0x00000000004081d0 in glusterfs_volumes_init (ctx=0xcb3010) at glusterfsd.c:1814
#12 0x0000000000408497 in main (argc=1, argv=0x7fffc5d90648) at glusterfsd.c:1898

Comment 1 Vijay Bellur 2013-03-21 21:06:58 UTC

CHANGE: http://review.gluster.org/4704 (rpc-transport: fix glusterd crash when rdma.so missing) merged in master by Anand Avati (avati)

Comment 2 Anand Avati 2013-04-12 13:19:18 UTC

REVIEW: http://review.gluster.org/4819 (rpc-transport: fix glusterd crash when rdma.so missing) posted (#1) for review on release-3.4 by Vijay Bellur (vbellur)

Comment 3 Anand Avati 2013-04-12 18:32:05 UTC

COMMIT: http://review.gluster.org/4819 committed in release-3.4 by Anand Avati (avati) 
------
commit b934b278be2a26a79b3715618ec4c368feb55ad9
Author: Rajesh Amaravathi <rajesh>
Date:   Thu Mar 21 16:40:16 2013 +0530

    rpc-transport: fix glusterd crash when rdma.so missing
    
    Add checks before trying to delete vol_opt from list and free
    
    Change-Id: I2858f58518394beb8f74fa477be81d7bdd38304f
    BUG: 924215
    Signed-off-by: Rajesh Amaravathi <rajesh>
    Reviewed-on: http://review.gluster.org/4704
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>
    Reviewed-on: http://review.gluster.org/4819
    Reviewed-by: Jeff Darcy <jdarcy>