Bug 924488

Summary:	NUFA and switch don't initialize DHT data structures properly
Product:	[Community] GlusterFS	Reporter:	Jeff Darcy <jdarcy>
Component:	distribute	Assignee:	Jeff Darcy <jdarcy>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.4.0-beta	CC:	fharshav, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-04-17 11:41:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	924490
Bug Blocks:

Description Jeff Darcy 2013-03-21 21:16:51 UTC

These derivative translators mostly call DHT functions, but their init/fini functions were copied from DHT long ago and haven't been kept up to date.  Therefore, they're not initializing the dht_conf_t properly before use.  This could lead to many problems from missing functionality to crashes.

Comment 1 Jeff Darcy 2013-03-21 23:34:34 UTC

http://review.gluster.org/4710

This ended up involving a lot more code than I expected, but it was all necessary work anywhere.  There were other bits and pieces of copied-and-pasted code (e.g. notify) that had the same maintainability issues.

Comment 2 Anand Avati 2013-07-24 21:52:17 UTC

REVIEW: http://review.gluster.org/5390 (Add switch and nufa options to 'gluster cli') posted (#1) for review on master by Harshavardhana (harsha)

Comment 3 Anand Avati 2013-07-24 22:03:02 UTC

REVIEW: http://review.gluster.org/5391 (Add switch and nufa options to 'gluster cli') posted (#1) for review on master by Harshavardhana (harsha)

Comment 4 Anand Avati 2013-07-25 00:16:11 UTC

REVIEW: http://review.gluster.org/5391 (Add switch and nufa options to 'gluster cli') posted (#2) for review on master by Harshavardhana (harsha)

Comment 5 Anand Avati 2013-07-25 02:07:26 UTC

REVIEW: http://review.gluster.org/5391 (Add switch and nufa options to 'gluster cli') posted (#3) for review on master by Harshavardhana (harsha)

Comment 6 Anand Avati 2013-08-02 01:40:36 UTC

REVIEW: http://review.gluster.org/5391 (Add switch and nufa options to 'gluster cli') posted (#4) for review on master by Harshavardhana (harsha)

Comment 7 Anand Avati 2013-08-04 06:47:43 UTC

COMMIT: http://review.gluster.org/5391 committed in master by Anand Avati (avati) 
------
commit 71d69e4331d7abff910e1f013bb7b2cb9d7f630c
Author: Harshavardhana <harsha>
Date:   Wed Jul 24 14:49:58 2013 -0700

    Add switch and nufa options to 'gluster cli'
    
    Change-Id: Ic3c43291e0e1ead0d89c0436e8d70aa5dee2f543
    BUG: 924488
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/5391
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

Comment 8 Niels de Vos 2014-04-17 11:41:05 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2014-07-11 18:15:35 UTC

*** Bug 987240 has been marked as a duplicate of this bug. ***