Bug 926374
| Summary: | protobuf: Does not support aarch64 in f19 and rawhide | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> | ||||
| Component: | protobuf | Assignee: | Lev Shamardin <shamardin> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | cse.cem+redhatbugz, mizdebsk, shamardin, sochotni | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | protobuf-2.5.0-3.fc19 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-05-14 04:37:47 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 922257 | ||||||
| Attachments: |
|
||||||
|
Description
Dennis Gilmore
2013-03-23 16:08:47 UTC
Protobuf already uses (2), I've bumped the revision number and started a build in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=5309029 I think this means we just need to bump / rebuild in all branches with autoconf >= 2.69. In fact, this isn't even needed in rawhide, 2.5.0 was already built with autoconf 2.69: http://kojipkgs.fedoraproject.org//packages/protobuf/2.5.0/1.fc19/data/logs/x86_64/root.log It's actually not even needed in F-18 (2.4.1) either: http://kojipkgs.fedoraproject.org//packages/protobuf/2.4.1/12.fc18/data/logs/x86_64/root.log Only F-17 was built with autoconf < 2.69 (2.68). Do we care about getting aarch64 into old-stable? I'm inclined to NOTABUG. I am reopening so we don't lose track of this because AARCH64 is also affected by bug 955577. Upstream dropped support for *a lot* of archs suddenly in 2.5.0. Need to look into implementing their atomic operations using GCC atomic ops. Looks like they support ARM 32-bit little-endian, as well as ppc32, but not 64-bit variants of either: https://code.google.com/p/protobuf/source/browse/trunk/src/google/protobuf/stubs/platform_macros.h If you have the hardware to test on, upstream is happy to take patches: https://code.google.com/p/protobuf/issues/detail?id=488 Created attachment 744146 [details] Proposed patch I have created a patch that uses generic gcc atomic operations on architectures that are not supported as first-class citizens. The patch has been submitted upstream as well[1] [1] https://code.google.com/p/protobuf/issues/detail?id=488#c3 Awesome! Have you tested the library on any of these platforms? The google bug just mentions building. (In reply to comment #7) > Awesome! Have you tested the library on any of these platforms? The google > bug just mentions building. I have tested clementine & muble work, but I don't know for sure which parts of protobuf they use. I would be surprised if they used these atomic functions though so it doesn't tell us much about my patch except it doesn't break working stuff :-) Sounds good to me. Scratch build in rawhide succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=5354666 Pushing to branches that have 2.5.0 now. F20 (rawhide) build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5355425 F19 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5355788 protobuf-2.5.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/protobuf-2.5.0-3.fc19 Package protobuf-2.5.0-3.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing protobuf-2.5.0-3.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-7863/protobuf-2.5.0-3.fc19 then log in and leave karma (feedback). protobuf-2.5.0-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |