Bug 926763
| Summary: | Review Request: trac-authopenid-plugin - Provide OpenID authentication for Trac | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrick Uiterwijk <puiterwijk> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-10 22:15:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Patrick Uiterwijk
2013-03-23 16:34:28 UTC
A new upstream release has been made with a new feature, version 0.4.2. Spec URL: http://puiterwijk.fedorapeople.org/packages/trac-authopenid-plugin/trac-authopenid-plugin.spec SRPM URL: http://puiterwijk.fedorapeople.org/packages/trac-authopenid-plugin/trac-authopenid-plugin-0.4.2-1.fc18.src.rpm I'll review this. Look for a full review in a bit... OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 2d85cf6aa3c40455846e534d12e18e6e06c628d4876d7758e46f707c336acb46 TracAuthOpenId-0.4.2.tar.gz 2d85cf6aa3c40455846e534d12e18e6e06c628d4876d7758e46f707c336acb46 TracAuthOpenId-0.4.2.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Minor nitpick: "This plugin allows to login to Trac using OpenID." reads oddly, perhaps: "This plugin allows users to login to Trac using OpenID." 2. rpmlint says: trac-authopenid-plugin.noarch: W: spelling-error %description -l en_US login -> loin, logic, lo gin trac-authopenid-plugin.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin 2 packages and 0 specfiles checked; 0 errors, 2 warnings. can be ignored. I don't see any blockers here, so this package is APPROVED. Happy to co-maintain. New Package SCM Request ======================= Package Name: trac-authopenid-plugin Short Description: Provide OpenID authentication for Trac Owners: puiterwijk Branches: f19 el6 InitialCC: kevin Git done (by process-git-requests). trac-authopenid-plugin-0.4.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-authopenid-plugin-0.4.2-1.el6 trac-authopenid-plugin-0.4.2-1.el6 has been pushed to the Fedora EPEL 6 testing repository. trac-authopenid-plugin-0.4.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |