Bug 927421

This isn't a full review but the spec is missing a BuildRequires on python-mock

(In reply to Tim Flink from comment #1)
> This isn't a full review but the spec is missing a BuildRequires on
> python-mock

Good catch; thanks.

I've fixed this and uploaded an updated specfile to the same location:
  http://dmalcolm.fedorapeople.org/python-packaging/python-firehose.spec

Successful scratch build in Koji:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=5446014

rpmlint warnings are as before.

(In reply to Dave Malcolm from comment #2)
> (In reply to Tim Flink from comment #1)
> > This isn't a full review but the spec is missing a BuildRequires on
> > python-mock
> 
> Good catch; thanks.
> 
> I've fixed this and uploaded an updated specfile to the same location:
>   http://dmalcolm.fedorapeople.org/python-packaging/python-firehose.spec
SRPM URL:
http://dmalcolm.fedorapeople.org/python-packaging/python-firehose-0.2-2.fc17.src.rpm

tl;dr: Package is approved. Minor (non-mandatory) changes can be made at import time.

TODO:
 * 'rm -rf %{buildroot}' can be removed from %install section, as no supported versions of Fedora or RHEL 6 require it.
 * Please request upstream to add a license note to setup.py or else add a LICENSE file (it's uncleare if lgpl-2.1.txt represents the project license, so setup.py is ambiguous.
 * 




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package requires other packages for directories it uses.
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package is not known to require ExcludeArch.
[ ]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-firehose
[ ]: Package complies to the Packaging Guidelines
[ ]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in /dev/shm/review/927421
     -python-firehose/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package consistently uses macro is (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Package must own all directories that it creates.
[ ]: Package does not own files or directories owned by other packages.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 184320 bytes in 28 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python-firehose-0.2-2.fc18.noarch.rpm
          python3-firehose-0.2-2.fc18.noarch.rpm
python-firehose.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters
python-firehose.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc
python-firehose.noarch: W: spelling-error %description -l en_US cppcheck -> checkup
python-firehose.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
python-firehose.noarch: W: spelling-error %description -l en_US roundtrips -> round trips, round-trips, roundups
python3-firehose.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters
python3-firehose.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc
python3-firehose.noarch: W: spelling-error %description -l en_US cppcheck -> checkup
python3-firehose.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
python3-firehose.noarch: W: spelling-error %description -l en_US roundtrips -> round trips, round-trips, roundups
2 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python3-firehose python-firehose
python3-firehose.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters
python3-firehose.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc
python3-firehose.noarch: W: spelling-error %description -l en_US cppcheck -> checkup
python3-firehose.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
python3-firehose.noarch: W: spelling-error %description -l en_US roundtrips -> round trips, round-trips, roundups
python-firehose.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters
python-firehose.noarch: W: spelling-error %description -l en_US gcc -> cc, g cc
python-firehose.noarch: W: spelling-error %description -l en_US cppcheck -> checkup
python-firehose.noarch: W: spelling-error %description -l en_US lossless -> loss less, loss-less, loveless
python-firehose.noarch: W: spelling-error %description -l en_US roundtrips -> round trips, round-trips, roundups
2 packages and 0 specfiles checked; 0 errors, 10 warnings.
# echo 'rpmlint-done:'



Requires
--------
python3-firehose (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)
    python3-six

python-firehose (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)
    python-six



Provides
--------
python3-firehose:
    python3-firehose

python-firehose:
    python-firehose



Source checksums
----------------
https://pypi.python.org/packages/source/f/firehose/firehose-0.2.tar.gz :
  CHECKSUM(SHA256) this package     : 61f362155aab7173e2011340fd014f00ca72bcef95865f39437f2f3576b19f33
  CHECKSUM(SHA256) upstream package : 61f362155aab7173e2011340fd014f00ca72bcef95865f39437f2f3576b19f33


Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29
Buildroot used: fedora-18-x86_64
Command line :/usr/bin/fedora-review -b 927421

(In reply to Stephen Gallagher from comment #4)
> tl;dr: Package is approved. Minor (non-mandatory) changes can be made at
> import time.

Thanks!


> TODO:
>  * 'rm -rf %{buildroot}' can be removed from %install section, as no
> supported versions of Fedora or RHEL 6 require it.

Removed (bumping to 0.2-3)

>  * Please request upstream to add a license note to setup.py or else add a
> LICENSE file (it's uncleare if lgpl-2.1.txt represents the project license,
> so setup.py is ambiguous.

I've fixed this in upstream git as:
https://github.com/fedora-static-analysis/firehose/commit/ba49ecebc4e2ae1f3fddd9d991935d28f453689f

New Package SCM Request
=======================
Package Name: python-firehose
Short Description: Library for working with output from static code analyzers
Owners: dmalcolm
Branches: f17 f18 f19 el6
InitialCC:

Git done (by process-git-requests).

python-firehose-0.2-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-firehose-0.2-3.fc19

python-firehose-0.2-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-firehose-0.2-3.fc18

python-firehose-0.2-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-firehose-0.2-3.fc17

python-firehose-0.2-3.fc19 has been pushed to the Fedora 19 stable repository.

python-firehose-0.2-3.fc17 has been pushed to the Fedora 17 stable repository.

python-firehose-0.2-3.fc18 has been pushed to the Fedora 18 stable repository.