Bug 928576 (iris-kadu)
| Summary: | Review Request: iris-kadu - A library for working with the XMPP/Jabber protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karol Trzcionka <karlikt> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dominik, drizt72, kevin, package-review, projects.rg, rdieter |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-15 16:20:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 928937, 863795 | ||
|
Description
Karol Trzcionka
2013-03-28 01:23:18 UTC
*** Bug 928574 has been marked as a duplicate of this bug. *** *** Bug 928572 has been marked as a duplicate of this bug. *** Quick comment: %doc sections in %files are empty. Why include them? Otherwise it looks fine. I'll try to do a full review this weekend if time permits. Sorry, the %doc was added by default in template. I'll fulfill it in next release (include COPYING at least) but I think I can wait for full review to fix it with other comments (if any). There is at least one external library bundled which have to be used from the Fedora repos instead of the bundled one: jdns: http://delta.affinix.com/jdns/ (Fedora: qjdns) The behavior of the project on top of iris-kadu is somewhat strange anyway. DeltaXMPP (https://delta.affinix.com/) seems to interlace the libraries and apps into each other arbitrarily, which makes it difficult to package certain components. However, jdns needs to be used from the Fedora package in any case. Moreover, we have a "iris" package, is it possible to use this instead of the -kadu version? (In reply to Mario Blättermann from comment #5) > Moreover, we have a "iris" package, is it possible to use this > instead of the -kadu version? No, as you can see in fpc ticket, I've tried to compile kadu with "iris" package but it's failed. The core library lacks of features so I need to use forked version. Both libraries can be installed in the system and they don't conflict. I don't think it makes sense to package an iris-kadu. The point of unbundling is to use the system iris (trying to merge the required patches into it), otherwise it might as well just stay bundled. Having a standalone iris-kadu package (of which kadu is the only user) brings no benefit over building this as part of kadu itself. Unbundling is only useful if you use the same library all the other packages use. I'm CCing the iris maintainer (hi Rex ;-) ). As for jdns, yes, iris itself bundles that. There's a patch to fix that in the iris package. Would it make sense to replace current libiris with kadu's forked version? On the other hand, I see there's been some movement in libiris upstream recently, so maybe the fork is no longer necessary? Fedora allready has jdns/qjdns package. No need to use bundled version. Closing here cause of FE-DEADREVIEW. |