Bug 928847

Thanks for the patch (and good catch with the makefile).

One thing I am not sure is this part:

-     | grep -E -o 'test\(/[^/)]+/[^/)]+/Library/[^/)]+\)' \
-     | sed -e 's|test(/[^/)]*/\([^/)]*\)/Library/\([^/)]*\))|\1/\2|g' \
+     | grep -E -o -e 'test\(/[^/)]+/[^/)]+/Library/[^/)]+\)' -e '[Ll]ibrary\([^)]*\)' \
+     | sed -e 's|test(/[^/)]*/\([^/)]*\)/Library/\([^/)]*\))|\1/\2|g' -e 's|[Ll]ibrary(\(.*\))|\1|' \

You have added second regex for something like "Library(Whatever)", why? What builds RPMs with such Provides?

As we discussed that with psss it should be done in beaker-wizard which would produce Makefile with following line
	@echo "Provides:        library(<component>/<lib_name>)" >> $(METADATA)

This will help test writer to not maintain whole library path / task name. And use it as follows

	@echo "RhtsRequires:    library(<component>/<lib_name>)" >> $(METADATA)

Also this could be slitted into the separate patch.

Okay, I was not aware of that discussion. Sound good. No need for separate patch, I already did that with git :)

However, it seems to me that the grep regex should be more restrictive, currently it will match things like 'Library(fubar)' or even 'Library()' 


[Ll]ibrary\([^)]+/[^)]+\) ?

I am ok with that. I did not handle that since there are some other checks in the code of rlImport so it was not crucial for me. Maybe we could even omit the '[Ll]' and leave just 'l'.

If you want to be more restrictive there could be even check for more slashes '/'. But still it seems to me that wrongly formated names are not destructive even if they are not catched by all the checks.

Hm, it's probably better to propagate the errors somewhere where they are actually logged. OK. I've just broken the patch in three separate ones (and I made a mistake, but the output is OK after all three of them :)

http://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=d739d33d46abe94a2b81935fa3a9dab7b88e97dc
http://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=b21c08d2bee7eb80d9f8dc7b03f0aae8d0511916
http://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=eea80e4ce9f910ce8a36fce5a322d0e5d4a36986

beakerlib-1.7-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/beakerlib-1.7-1.fc19

Package beakerlib-1.7-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.7-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-7067/beakerlib-1.7-1.fc19
then log in and leave karma (feedback).

beakerlib-1.7-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.