Bug 947010

Summary: [fork][v2carts] Can not restart diy application successfully if diy is already stopped.
Product: OKD Reporter: Yujie Zhang <yujzhang>
Component: ContainersAssignee: Dan Mace <dmace>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: dmace, miyang, xjia, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: devenv_3119+ Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-20 03:36:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
mcolloective.log
none
broker log none

Description Yujie Zhang 2013-04-01 08:03:05 UTC 
Created attachment 730206 [details]
mcolloective.log

Description of problem:

Created a diy application, restart it from website, it will say "The app has been restarted", but the url of the app can not be accessed, and sshed to the app, found that the service is not running.Restart it using CLI, met "Reference ID: 9f034c748bf4b88954e5fd47f03bd05b" error.

Created a diy application, stopped it using CLI firstly, then restart it from website or CLI, can not be successfully. Met "We appear to be having technical difficulties" error from website and met "Reference ID: 9f034c748bf4b88954e5fd47f03bd05b" error from CLI.

Details see attachment of mcollective log and broker log.


Version-Release number of selected component (if applicable):
devenv_3020

How reproducible:
always

Steps to Reproduce:
1.Create a diy application
2.Restart the application from website or CLI
3.
  
Actual results:

Met "We appear to be having technical difficulties" error from website and met "Reference ID: 9f034c748bf4b88954e5fd47f03bd05b" error from CLI. Details see attachment of mcollective log and broker log.

RestAPI result as following:

[root@dhcp-8-252 home]# curl -k -X POST -H 'Accept: application/xml' -d event=restart --user aaa:redhat https://ec2-107-22-14-15.compute-1.amazonaws.com/broker/rest/domains/jdghdgh/applications/diy353/events
<?xml version="1.0" encoding="UTF-8"?>
<response>
  <status>internal_server_error</status>
  <type nil="true"></type>
  <data>
    <datum nil="true"></datum>
  </data>
  <messages>
    <message>
      <severity>error</severity>
      <text>
Reference ID: 8325b1e2cf9f12baca3170ccf4027e30</text>
      <exit-code>-1</exit-code>
      <field nil="true"></field>
    </message>
  </messages>
  <version>1.4</version>
  <supported-api-versions>
    <supported-api-version>1.0</supported-api-version>
    <supported-api-version>1.1</supported-api-version>
    <supported-api-version>1.2</supported-api-version>
    <supported-api-version>1.3</supported-api-version>
    <supported-api-version>1.4</supported-api-version>
  </supported-api-versions>
  <errors/>
</response>


Expected results:


Additional info:
Comment 1 Yujie Zhang 2013-04-01 08:03:34 UTC 
Created attachment 730207 [details]
broker log
Comment 2 chris alfonso 2013-04-10 15:35:33 UTC 
Fix is in in devenv_3057
Comment 3 xjia 2013-04-12 08:06:39 UTC 
Now success to restart the diy app.
But if the app is stopped, then restart the app, it will show "We appear to be having technical difficulties"

Version:
devenv_3081
Comment 4 yangmingzhi 2013-04-12 09:19:16 UTC 
To xjia:
    When I stop the app that is already stopped for the second time,
    it shows me the following outputs:
    (it's different from what you see.)

[root@hcx ~]# rhc app stop app1

Reference ID: f9d4c97afd551c897e31dc4be9a286c5
[root@hcx ~]# rhc app stop app1

Reference ID: 031fb5d2ccbd9bbdef3c0f42e0229f31
[root@hcx ~]#

And when I run "echo $?", it returned "1"
[root@hcx ~]# echo $?
1
[root@hcx ~]#
Comment 5 chris alfonso 2013-04-12 13:58:43 UTC 
Thanks for finding this one.  I've openened a pull request for this fix.

https://github.com/openshift/origin-server/pull/2039
Comment 6 xjia 2013-04-15 05:54:00 UTC 
Verify:
[root@jasontest ~]# rhc app stop diy
RESULT:
diy stopped
[root@jasontest ~]# rhc app restart diy
RESULT:
diy restarted
[root@jasontest ~]# rhc app show --state diy
Cartridge diy-0.1, mysql-5.1 is started

Version:
devenv_3094

You can move this bug ON_QA. Thanks.
Comment 7 Yujie Zhang 2013-04-18 05:40:30 UTC 
Tested on devenv_3115 , it can be successfull when restarting a stopped application, but when stopping a stopped application, there is still reference error like following:

[root@dhcp-8-252 home]# rhc app stop -a doitself45 -l ss
RESULT:
doitself45 stopped
[root@dhcp-8-252 home]# rhc app stop -a doitself45 -l ss

Reference ID: 353ac711299e408cf282fd951334a33d

So assign it back,thanks.
Comment 8 Dan Mace 2013-04-18 14:58:21 UTC 
Resolved by https://github.com/openshift/origin-server/pull/2137
Comment 9 openshift-github-bot 2013-04-18 17:37:32 UTC 
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/f7479cf7447fa074f13004844f655cdc85231a3a
Bug 947010: Exclude grep when checking for existing process

Resolve https://bugzilla.redhat.com/show_bug.cgi?id=947010
Comment 10 xjia 2013-04-19 10:20:06 UTC 
[root@ip-10-73-29-105 ~]# rhc app stop diy
RESULT:
diy stopped
[root@ip-10-73-29-105 ~]# rhc app stop diy
RESULT:
diy stopped

Version:
devenv_3120