Bug 947387
| Summary: | Running domain may disappear after libvirtd is restarted when selinux security driver is disabled | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Michal Privoznik <mprivozn> | |
| Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> | |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 6.5 | CC: | acathrow, cwei, dallan, dyuan, gsun, lnovich, mzhan, ydu | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | libvirt-0.10.2-20.el6 | Doc Type: | Bug Fix | |
| Doc Text: |
Cause:
Libvirt uses an side files to store the internal state of managed domains in order to re-read the state upon libvirtd service restart. However, if the state was saved in inconsistent state, the state wasn't re-read and the corresponding domain was lost.
Consequence:
The domain may disappear.
Fix:
When the libvirtd service is saving the internal state of a domain, the consistent internal state is saved and domains which may break it are disallowed to be started up.
Result:
The domain is not longer frogotten.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1106440 (view as bug list) | Environment: | ||
| Last Closed: | 2013-11-21 08:58:07 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1106440 | |||
|
Description
Michal Privoznik
2013-04-02 10:08:36 UTC
Moving to POST:
commit 8d68cbeaa8a64759323da1d64526e2a941eb93e1
Author: Michal Privoznik <mprivozn>
AuthorDate: Tue Apr 2 17:49:34 2013 +0200
Commit: Michal Privoznik <mprivozn>
CommitDate: Wed Apr 3 10:19:46 2013 +0200
sec_manager: Refuse to start domain with unsupported seclabel
https://bugzilla.redhat.com/show_bug.cgi?id=947387
If a user configures a domain to use a seclabel of a specific type,
but the appropriate driver is not accessible, we should refuse to
start the domain. For instance, if user requires selinux, but it is
either non present in the system, or is just disabled, we should not
start the domain. Moreover, since we are touching only those labels we
have a security driver for, the other labels may confuse libvirt when
reconnecting to a domain on libvirtd restart. In our selinux example,
when starting up a domain, missing security label is okay, as we
auto-generate one. But later, when libvirt is re-connecting to a live
qemu instance, we parse a state XML, where security label is required
and it is an error if missing:
error : virSecurityLabelDefParseXML:3228 : XML error: security label
is missing
This results in a qemu process left behind without any libvirt control.
v1.0.4-22-g8d68cbe
Huh, for some reason this bug was in POST, but the patch hasn't been backported. So here's the patch: http://post-office.corp.redhat.com/archives/rhvirt-patches/2013-July/msg00332.html # rpm -q libvirt libvirt-0.10.2-20.el6.x86_64 Following the reproduce steps in comment 0 when start the guest, get expect error # virsh start virtlab_test error: Failed to start domain virtlab_test error: unsupported configuration: Unable to find security driver for label selinux So this bug can VERIFIED. BTW, if remove the configuration: security_driver = "none", restart libvirtd, when start the domain, libvirtd will crash, there's a new bug 984793 to track this problem. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-1581.html |