Bug 948105

Hello, Ricky:
If you want review swap, I would appreciate it if you would swap this bug with one of my review requests (e.g. bug 922460 ).

By the way, "ruby(release)" is provided by ruby only on F-19+, not on F-18 and below while your srpm contains ".fc18". Is this what you intended?

Anyway taking.

Oh, please upload srpm, not rebuilt rpm, thank you.

* BuildRequires
  - srpm rebuilt from your spec file won't build on koji F20.
    Please add appropriate BuildRequires (at least rubygem-devel is
    needed)

* Documentation etc
  - Please mark AUTHORS CHANGES COPYING README.md %{gem_docdir} as %doc
    (at least COPYING must be marked as %doc)
  - INSTALLING file is not needed as installing is done by rpm
  - Also Rakefile is not needed as Rakefile is like Makefiles in
    autotools based files, which we do not package into binary rpms.
  - It is recommended to split out %gem_docdir into -doc rpm.
  - test/ directory should not be packaged into binary rpm:
    https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites

* Virtual Requires
  - For (Build)Requires, please use "Requires: rubygem(hpricot)" style instead of
    directly writing rpms' names (i.e. instead of "Requires: rubygem-hpricot")
    so as to be consistent of other packages.

* Running test suites
  - As this gem contains test/ directory, please add %check seciton and
    execute some test program in %check:
    https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites

Thanks for the feedback, and sorry I uploaded the wrong RPM, I didn't even notice. :)

I believe I've addressed everything you've pointed out so far - and yes, I will happily review one of yours in return. Look for it tomorrow.

New SRPM: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn-0.7.3-2.fc18.src.rpm
New Spec: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn.spec

For -2:

* Requires etc
  - On F-19+, rubygem-based rpm must have "Requires: ruby(release)"
    and On F-18-, rubygem-based rpm must have "Requires: ruby(abi) = 1.9.1".
    One trick is
%if 0%{?fedora} >= 19
Requires: ruby(release)
%else
Requires: ruby(abi) = 1.9.1
%endif

* Documentation
  - What I meant is that %gem_instdir/AUTHORS and etc should be marked as %doc.
    Currently these files (%gem_instdir/AUTHORS, %gem_instdir/CHANGES, etc)
    are not marked as %doc, and the same files are copied into
    /usr/share/doc/%{name}-%{version} (with marked as doc).

    It is recommended to write %files entry more verbosely, like
%files
%dir %{gem_instdir}
%doc %{gem_instdir}/[A-Z]*
%{gem_libdir}
%{gem_instdir}/foobar
....

  - Also, rm -rf %{buildroot}%{gem_dir}/{INSTALLING,Rakefile,test} should be
    rm -rf %{buildroot}%{gem_instdir}/{INSTALLING,Rakefile,test}

New SRPM: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn-0.7.3-3.fc19.src.rpm
New Spec: http://codeblock.fedorapeople.org/packages/rubygem-ronn/rubygem-ronn.spec

Thanks for explaining the F18- and F19+ trick. And hopefully I got the %files section right this time. :)

Okay, clean.

----------------------------------------------------------------
    This package (rubygem-ronn) is APPROVED by mtasaka
----------------------------------------------------------------

New Package SCM Request
=======================
Package Name: rubygem-ronn
Short Description: Manual authoring tool
Owners: codeblock
Branches: f18 f19

Git done (by process-git-requests).

Would you build this package on koji?

Yep, will do so right now.

rubygem-ronn-0.7.3-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rubygem-ronn-0.7.3-3.fc19

Okay, thank you.

rubygem-ronn-0.7.3-3.fc19 has been pushed to the Fedora 19 testing repository.

rubygem-ronn-0.7.3-3.fc19 has been pushed to the Fedora 19 stable repository.