Bug 948626
| Summary: | Review Request: python-flask-mako - Mako templating support for Flask applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Patrick Uiterwijk <puiterwijk> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, pingou, puiterwijk |
| Target Milestone: | --- | Flags: | puiterwijk:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-03 08:46:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ralph Bean
2013-04-04 21:05:46 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5213745 I'll review this one OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License BSD OK - License field in spec matches NO - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 9d30e7826e13c31793bbad333b7434ce Flask-Mako-0.2.tar.gz 9d30e7826e13c31793bbad333b7434ce Flask-Mako-0.2.tar.gz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: Checking: python-flask-mako-0.2-1.fc18.noarch.rpm python-flask-mako.noarch: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python-flask-mako.noarch: W: summary-ended-with-dot C Mako templating support for Flask applications. python-flask-mako.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting 1 packages and 0 specfiles checked; 0 errors, 3 warnings. You can ignore those, if you use the spec file on your website rather than the one in the SRPM, as that one fixes the summary-ended-with-dot. This is APPROVED. New Package SCM Request ======================= Package Name: python-flask-mako Short Description: Mako templating support for Flask applications Owners: ralph Branches: f19 f18 f17 el6 InitialCC: Git done (by process-git-requests). python-flask-mako-0.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-flask-mako-0.2-1.fc19 python-flask-mako-0.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-flask-mako-0.2-1.fc18 python-flask-mako-0.2-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-flask-mako-0.2-1.fc17 python-flask-mako-0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-flask-mako-0.2-1.el6 python-flask-mako-0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. python-flask-mako-0.2-1.fc17 has been pushed to the Fedora 17 stable repository. python-flask-mako-0.2-1.fc18 has been pushed to the Fedora 18 stable repository. python-flask-mako-0.2-1.fc19 has been pushed to the Fedora 19 stable repository. Package Change Request ====================== Package Name: python-flask-mako New Branches: epel7 Owners: ralph InitialCC: Git done (by process-git-requests). |