Bug 948753 (Horde_Oauth)

Summary: Review Request: php-horde-Horde-Oauth - Horde OAuth client/server
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: nb, package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: php-horde-Horde-Oauth-2.0.1-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-18 07:55:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
phpcompatinfo.log
none
fedora-review.txt none

Description Remi Collet 2013-04-05 10:44:03 UTC 
Spec URL: https://raw.github.com/remicollet/remirepo/1f79b4f6af7eaf5190bbb7cf5d1bfe131f106911/php/horde/php-horde-Horde-Oauth/php-horde-Horde-Oauth.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Oauth-2.0.1-1.remi.src.rpm
Description: 
An OAuth consumer (http://oauth.net) and OAuth infrastructure, and in the
future will provide an OAuth server.

Fedora Account System Username: remi
Comment 1 Shawn Iwinski 2014-01-11 16:55:50 UTC 
Created attachment 848651 [details]
phpcompatinfo.log

phpcompatinfo version 2.26.0
Comment 2 Shawn Iwinski 2014-01-11 16:56:34 UTC 
Created attachment 848652 [details]
fedora-review.txt

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -b 970930
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Comment 3 Shawn Iwinski 2014-01-11 17:02:16 UTC 
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

Remove EPEL5 bits after initial import.


[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM

     Acceptable diff.

Diff spec file in url and in SRPM
---------------------------------
--- /home/siwinski/projects/fedora/reviews/970930-php-horde-Horde-HashTable/srpm/php-horde-Horde-HashTable.spec	2014-01-11 09:09:28.860000000 -0500
+++ /home/siwinski/projects/fedora/reviews/970930-php-horde-Horde-HashTable/srpm-unpacked/php-horde-Horde-HashTable.spec	2013-07-25 04:52:58.000000000 -0400
@@ -1,5 +1,5 @@
 # spec file for php-horde-Horde-HashTable
 #
-# Copyright (c) 2013-2014 Remi Collet
+# Copyright (c) 2013 Remi Collet
 # License: CC-BY-SA
 # http://creativecommons.org/licenses/by-sa/3.0/


No blockers.


===== APPROVED =====
Comment 4 Shawn Iwinski 2014-01-11 17:04:23 UTC 
Nevermind previous comment -- that was for another package.

[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

Remove EPEL5 bits after initial import.


No blockers.


===== APPROVED =====
Comment 5 Remi Collet 2014-01-11 17:24:09 UTC 
New Package SCM Request
=======================
Package Name: php-horde-Horde-Oauth
Short Description: Horde OAuth client/server
Owners: remi
Branches: f20 el6
InitialCC:
Comment 6 Gwyn Ciesla 2014-01-13 13:17:48 UTC 
Git done (by process-git-requests).
Comment 7 Fedora Update System 2014-01-13 15:44:02 UTC 
php-horde-Horde-Oauth-2.0.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/php-horde-Horde-Oauth-2.0.1-1.fc20
Comment 8 Fedora Update System 2014-01-13 15:44:16 UTC 
php-horde-Horde-Oauth-2.0.1-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Oauth-2.0.1-1.el6
Comment 9 Fedora Update System 2014-01-13 20:08:45 UTC 
php-horde-Horde-Oauth-2.0.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 10 Fedora Update System 2014-01-22 03:12:53 UTC 
php-horde-Horde-Oauth-2.0.1-1.fc20 has been pushed to the Fedora 20 stable repository.
Comment 11 Fedora Update System 2014-01-28 21:06:10 UTC 
php-horde-Horde-Oauth-2.0.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.