Bug 949845
| Summary: | [RFE][RHEL5] Rebase to nss-3.14.3 to fix the lucky-13 issue | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Libor Miksik <lmiksik> |
| Component: | nss | Assignee: | Elio Maldonado Batiz <emaldona> |
| Status: | CLOSED ERRATA | QA Contact: | Aleš Mareček <amarecek> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.10 | CC: | amarecek, bgollahe, cschalle, dpal, emaldona, eparis, huzaifas, jgalipea, jrieden, kengert, ksrot, pm-eus, rrelyea, sforsber, stransky, thoger, tpelka |
| Target Milestone: | rc | Keywords: | FutureFeature, Rebase, ZStream |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nss-3.14.3-5.el5_9 | Doc Type: | Rebase: Bug Fixes and Enhancements |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-05 15:55:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 918948, 973656 | ||
| Bug Blocks: | |||
| Attachments: | |||
|
Description
Libor Miksik
2013-04-09 07:19:28 UTC
Code review changes at https://bugzilla.redhat.com/show_bug.cgi?id=918948#c10 I'll attach next deltas relative to what has already been pushed to git. That code review done for rhel-5.10 is applicable here. Created attachment 733416 [details]
Changes requested from the code review
Created attachment 733417 [details]
Changes requested from the code review V2 plus other stuff I noticed
Revised previous to drop the sharedb versions ot the blank db's and the pkcs11.txt config file from the sources list as we aren't installing them.
I should remove the BuildRequires: sqlite-devel line. Comment on attachment 733417 [details]
Changes requested from the code review V2 plus other stuff I noticed
r- This doesn't turn off sqlite, it builds an NSS with it's own copy of sqlite, which will then either 1) overwrite the system sqlite (bad), or 2) won't work because it can't find the symbols it needs in the system sqlite library (also bad).
bob
Created attachment 735050 [details]
changes requested from the code review V3
Created attachment 738161 [details]
changes to rebase from nss-3.13.6-2 to nss-3.14.3-3
Comment on attachment 738161 [details]
changes to rebase from nss-3.13.6-2 to nss-3.14.3-3
r+ let me review the sqlite patch as well, but the spec looks goo.
Comment on attachment 738161 [details]
changes to rebase from nss-3.13.6-2 to nss-3.14.3-3
ok, it's there in the big diff...
r+ stands, it's ready to go.
bob
Created attachment 738708 [details]
use old sqlite api's on rhel-5 if at all
Created attachment 738710 [details]
ignore system sqlite as it can't be supported on rhel-5
Created attachment 747462 [details]
Required RHEL-5 only changes to add& set NO_FORK_CHECK to keep ABI semantics
Created attachment 747464 [details]
Required RHEL-5 only changes to add& set NO_FORK_CHECK to keep ABI semantics
Same as previous version but needed to fix a couple of incorrect comments.
Comment on attachment 747464 [details]
Required RHEL-5 only changes to add& set NO_FORK_CHECK to keep ABI semantics
r+
Though I need a few questions answered: What is nss-nochktest.patch. clearly you meant to remove it because it's in the comments, but I don't think it's related to fork check.
Where is the actual fork check patch. the diff is just the .spec file.
bob
OK, the diff button didn't show the forkcheck patch file, but it's there. r+ stands. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-1135.html |