Bug 950041
| Summary: | Review Request (rename): nodejs-less - The dynamic stylesheet language | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stephen Gallagher <sgallagh> |
| Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jamielinux, mrunge, notting, package-review, tchollingsworth |
| Target Milestone: | --- | Flags: | mrunge:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-04-20 20:04:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 857843 | ||
| Bug Blocks: | 958484 | ||
|
Description
Stephen Gallagher
2013-04-09 13:57:56 UTC
I'm renaming the 'lessjs' package to be in line with the Node.js packaging guidelines (as it is a pure Node package). It upgrades cleanly from the old version. Thank you in advance for your review. Sadly, the build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=5236458 + chmod a+x bin/lessc + cp -rp bin package.json lib/less/browser.js lib/less/colors.js lib/less/functions.js lib/less/index.js lib/less/lessc_helper.js lib/less/parser.js lib/less/rhino.js lib/less/tree lib/less/tree.js '/builddir/build/BUILDROOT/nodejs-less-1.3.3-2.fc20.noarch/%{nodejs_sitelib}/less' cp: target '/builddir/build/BUILDROOT/nodejs-less-1.3.3-2.fc20.noarch/%{nodejs_sitelib}/less' is not a directory The root cause seems to be, %{nodejs_sitelib} is not defined (at least in rawhide): + mkdir -p '/builddir/build/BUILDROOT/nodejs-less-1.3.3-2.fc20.noarch%{nodejs_sitelib}/less' According to the packaging guidelines, your code is correct. - Could you please also change the permissions on less-1.3.3.tgz? nodejs-less.src: W: strange-permission less-1.3.3.tgz 0444L I don't see this as really critical, just a non-blocking minor. Else it looks good to me. Since it's a rename, esp. obsoletes are correct to me. Yeah, I just realized that I was doing BuildRequires: nodejs instead of BuildRequires: nodejs-devel That fixes it: http://koji.fedoraproject.org/koji/taskinfo?taskID=5237160 Spec: http://sgallagh.fedorapeople.org/packagereview/nodejs-less/nodejs-less.spec SRPM: http://sgallagh.fedorapeople.org/packagereview/nodejs-less/nodejs-less-1.3.3-3.fc18.src.rpm (In reply to comment #2) > - Could you please also change the permissions on less-1.3.3.tgz? > nodejs-less.src: W: strange-permission less-1.3.3.tgz 0444L > I don't see this as really critical, just a non-blocking minor. Actually, I have no idea how to change this right now. It was apparently uploaded that way to the lookaside cache. I suppose it would have to be a rel-eng fix. I'll make sure to correct this when 1.4 final is released. OK, package approved! New Package SCM Request ======================= Package Name: nodejs-less Short Description: Less.js The dynamic stylesheet language Owners: sgallagh mrunge patches jamielinux Branches: f19 f18 el6 InitialCC: Git done (by process-git-requests). nodejs-less-1.3.3-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-less-1.3.3-3.fc19 nodejs-less-1.3.3-3.fc19 has been pushed to the Fedora 19 testing repository. nodejs-less-1.3.3-3.fc19 has been pushed to the Fedora 19 stable repository. |