Bug 950444

Summary:	inspection fails if libosinfo is not installed
Product:	[Fedora] Fedora	Reporter:	Richard W.M. Jones <rjones>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	19	CC:	acathrow, crobinso, mbooth, rjones, virt-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	948324	Environment:
Last Closed:	2013-12-16 18:56:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	948324
Bug Blocks:

Description Richard W.M. Jones 2013-04-10 09:03:18 UTC

+++ This bug was initially created as a clone of Bug #948324 +++

Description of problem:

(Reported by Georg Troxler)

Inspection is supposed to ignore missing libosinfo database.
However the current code fails if it cannot open the database
which is not right.

See for example:

https://www.redhat.com/archives/libguestfs/2013-April/msg00016.html

Version-Release number of selected component (if applicable):

libguestfs 1.20 & 1.21.

--- Additional comment from Richard W.M. Jones on 2013-04-10 05:00:54 EDT ---

The way to reproduce this is to run inspection on an ISO
of an older operating system that doesn't use a universal
multiboot installer.  I'm using a Windows XP install disk:

$ virt-inspector -v en_windows_xp_professional_with_service_pack_3_x86_cd_x14-80428.iso
[...]
libguestfs: osinfo: /usr/share/libosinfo/db/oses: No such file or directory
[...]

--- Additional comment from Richard W.M. Jones on 2013-04-10 05:02:19 EDT ---

Fixed upstream:
https://github.com/libguestfs/libguestfs/commit/b72daebaf4a859769455a1db70a40603cb5597be

Comment 1 Cole Robinson 2013-12-16 18:56:58 UTC

F18 is end-of-life soon, not sure if this patch landed there but it should be in F19+, so closing.