Bug 950893

Summary: remove existing efi entries when uninstall rhev-h in uefi mode machine.
Product: Red Hat Enterprise Linux 6 Reporter: haiyang,dong <hadong>
Component: ovirt-nodeAssignee: Fabian Deutsch <fdeutsch>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: low    
Version: 6.5CC: acathrow, bsarathy, cboyle, cshao, fdeutsch, gouyang, hadong, huiwa, jboggs, leiwang, mburns, ovirt-maint, tlavigne, ycui
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-node-3.0.1-5.el6 Doc Type: Enhancement
Doc Text:
When uninstalling the hypervisor in a uefi mode machine, efi entries weren't being removed. Now after uninstalling the hypevisor in a uefi mode machine it removes the existing efi entries This can be checked by rebooting from uefi mode.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 19:31:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description haiyang,dong 2013-04-11 07:27:21 UTC
Description of problem:
Insert the installation media(CD-ROM/USB) in uefi mode machine, and start the system, When the automatic boot prompt appears, press Enter.
then selected boot option "Uninstall" to uninstall existing rhev-h
After uninstall rhev-h in uefi mode machine success, then reboot machine from uefi mode,but still noticed that efi entries exist on uefi mode.

#remove existing efi entries patch
                efi_mgr_cmd = "efibootmgr|grep '%s'" % PRODUCT_SHORT
                efi_mgr = subprocess_closefds(efi_mgr_cmd, shell=True, \
                                              stdout=PIPE, stderr=STDOUT)
                efi_out = efi_mgr.stdout.read().strip()
                logger.debug(efi_mgr_cmd)
                logger.debug(efi_out)
                for line in efi_out.splitlines():
                    if not "Warning" in line:
                        num = line[4:8] # grabs 4 digit hex id
                        cmd = "efibootmgr -B -b %s" % num
                        system(cmd)

Version-Release number of selected component (if applicable):
rhev-hypervisor-advanced-6.4-20130410.0.el6ev

How reproducible:
100% 
 
Steps to Reproduce:
1.Insert the installation media(CD-ROM/USB) in uefi mode, and start the system.
2.Start the system. When the automatic boot prompt appears, press Enter.
3.selected boot option "Uninstall".

Actual result:
After uninstall rhev-h in uefi mode machine success, then reboot machine from uefi mode,but still noticed that efi entries exist on uefi mode.

Expect result:
After uninstall rhev-h in uefi mode machine success, then reboot machine from uefi mode,
it should remove existing efi entries

Additional info:
1.[root@dhcp-10-195 admin]# efibootmgr |grep "RHEV Hypervisor Advanced"
Boot0009* RHEV Hypervisor Advanced
[root@dhcp-10-195 admin]# efibootmgr -B -b 0009
BootCurrent: 0009
Timeout: 1 seconds
BootOrder: 0004,0001,0002,0000,0003,0006,0007,0008,0005,0013
Boot0000* Diskette Drive
Boot0001* SAMSUNG HD322GM
Boot0002* USB Storage Device
Boot0003* CD/DVD/CD-RW Drive
Boot0004* Onboard NIC
Boot0005* CDROM
Boot0006* RHEV Hypervisor
Boot0007* oVirt Node Hypervisor
Boot0008* oVirt Node Hypervisor
Boot0013* UEFI: INT13(RAID,0x80)
BootFFFA* Internal Shell       
BootFFFB* Diagnostic Boot      
BootFFFC* Temporary Boot Menu  
BootFFFD* Graphic Setup        
BootFFFE* Text Setup           
[root@dhcp-10-195 admin]# efibootmgr |grep "RHEV Hypervisor Advanced"
2.reboot rhev-h, it have removed existing efi entry "RHEV Hypervisor Advanced"

Comment 2 Fabian Deutsch 2013-09-16 15:32:28 UTC
The fix landed in upstream 3.0

Comment 3 Fabian Deutsch 2013-09-19 10:30:29 UTC
Not all EFI fixes landed in upstream 3.0.1:

9a436357e188f4209cb145ccbad9f95543e08638
[efi-fixes bd3ff17] installer: Fix EFI boot entry removal
 3 files changed, 142 insertions(+), 24 deletions(-)

be189b35c16f3dbbf295f2164bc4e4d4d3f3552b
[efi-fixes 9769dd7] remove existing efi entries when uninstall rhev-h in efi boot
 Author: hadong <hadong0720>
 1 file changed, 5 insertions(+)

a3f6f8fb9f9d98c33b9bac23482be1fa10b28141
[efi-fixes 3a3774d] Fix EFI boot entry shown "fedora" issue
 Author: hadong <hadong0720>
 1 file changed, 11 insertions(+), 5 deletions(-)

We need to backport them.

Comment 5 haiyang,dong 2013-10-28 09:30:53 UTC
Test version:
rhevh-6.5-20131024.1.0.iso
ovirt-node-3.0.1-6.el6.noarch

Test Steps:
1.Insert the installation media(CD-ROM/USB) in uefi mode, and start the system.
2.Start the system. When the automatic boot prompt appears, press Enter.
3.selected boot option "Uninstall".

Test result:
After uninstall rhev-h in uefi mode machine success, then reboot machine from uefi mode,it has removed existing efi entries.

so this bug has been fixed, change it into "VERIFIED"

Comment 8 Cheryn Tan 2013-11-08 00:35:39 UTC
This bug is currently attached to errata RHBA-2013:15277. If this change is not to be documented in the text for this errata please either remove it from the errata, set the requires_doc_text flag to minus (-), or leave a "Doc Text" value of "--no tech note required" if you do not have permission to alter the flag.

Otherwise to aid in the development of relevant and accurate release documentation, please fill out the "Doc Text" field above with these four (4) pieces of information:

* Cause: What actions or circumstances cause this bug to present.
* Consequence: What happens when the bug presents.
* Fix: What was done to fix the bug.
* Result: What now happens when the actions or circumstances above occur. (NB: this is not the same as 'the bug doesn't present anymore')

Once filled out, please set the "Doc Type" field to the appropriate value for the type of change made and submit your edits to the bug.

For further details on the Cause, Consequence, Fix, Result format please refer to:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes 

Thanks in advance.

Comment 10 errata-xmlrpc 2014-01-21 19:31:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0033.html