Bug 951473

Summary:	cluster.min-free-disk
Product:	[Community] Gluster-Documentation	Reporter:	Nagilum <bugzilla>
Component:	Other	Assignee:	Anjana Suparna Sriram <asriram>
Status:	ASSIGNED ---	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	bugs, ccalhoun
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nagilum 2013-04-12 09:51:57 UTC

Description of problem:
The documentation for this is:
"Specifies the percentage of disk space that must be kept free. Might be
useful for non-uniform bricks."

It remains unclear what happens if less disk space is free. If there are no consequences then what's the point of having this?

Version-Release number of selected component (if applicable):
3.3

Comment 1 Amar Tumballi 2013-04-12 11:40:36 UTC

Thanks for pointing this out.. We recently fixed this in upstream, and haven't yet backported to 3.3.x branch. The release-3.4 series will have the right fix.

-Amar
-----

commit 2f60c8a4776a6052cfba43605263dd32c616cfa2
Author: Avra Sengupta <asengupt>
Date:   Thu Jan 17 14:46:30 2013 +0530

    glusterd/cli: Updated the options descriptions for "volume set help"
    
    Change-Id: I0db00b7334bb9707ab48bd661ac03a3ad818d6e4
    BUG: 893458
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/4393
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Anand Avati <avati>

diff --git a/xlators/cluster/dht/src/dht.c b/xlators/cluster/dht/src/dht.c
index d70d713..bb4d70e 100644
--- a/xlators/cluster/dht/src/dht.c
+++ b/xlators/cluster/dht/src/dht.c
@@ -578,18 +578,23 @@ struct volume_options options[] = {
                     "on", "off"},
           .type = GF_OPTION_TYPE_STR,
           .default_value = "on",
+          .description = "This option if set to ON, does a lookup through "
+          "all the sub-volumes, in case a lookup didn't return any result "
+          "from the hash subvolume. If set to OFF, it does not do a lookup "
+          "on the remaining subvolumes."
         },
         { .key  = {"min-free-disk"},
           .type = GF_OPTION_TYPE_PERCENT_OR_SIZET,
           .default_value = "10%",
-          .description = "Percentage/Size of disk space that must be "
-                         "kept free."
+          .description = "Percentage/Size of disk space, after which the "
+          "process starts balancing out the cluster, and logs will appear "
+          "in log files",
         },
        { .key  = {"min-free-inodes"},
           .type = GF_OPTION_TYPE_PERCENT,
           .default_value = "5%",
-          .description = "Percentage inodes that must be "
-                         "kept free."
+          .description = "after system has only N% of inodes, warnings "
+          "starts to appear in log files",
         },
         { .key = {"unhashed-sticky-bit"},
           .type = GF_OPTION_TYPE_BOOL,
----