Bug 951823

* rpmlint only finds a few incorrect-fsf-address issues:
  https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

  Reported: https://sourceforge.net/tracker/?group_id=257241&atid=1551608


* sidplayfp options --none and --nosid segfault. Reported:
  https://sourceforge.net/tracker/?func=detail&aid=3611237&group_id=257241&atid=1551608


* stilview usage txt refers to USAGE.txt file that isn't packaged. Reported:
  https://sourceforge.net/tracker/?group_id=257241&atid=1551608

Run-time test:
$ HVSC_BASE=/home/ms19a/Music/INCOMING/HVSC/C64Music stilview -e=/DEMOS/0-9/3_Oversample.sid 
  TITLE: Get Ready
 ARTIST: Jeroen Tel
COMMENT: Same as /MUSICIANS/T/Tel_Jeroen/HCS_etc/Get_Ready.sid, but with digis
         added and with voice 1 largely muted.


* Build with pulseaudio and ALSA?

  $ grep alsa sidplayfp.spec 
  BuildRequires:  libsidplayfp-devel alsa-lib-devel pulseaudio-libs-devel
  $ rpm -qR sidplayfp|grep alsa
  $

Somebody has reported it already:
https://sourceforge.net/tracker/?func=detail&aid=3609103&group_id=257241&atid=1551608


* Run-time test: It's expected that with no ROM images available, some sids that did play with libsidplay1 are just silent (since old libsidplay set up fake interrupts, e.g. CIA Timer IRQs, for non VBI-speed playback). Installing the non-free "vice-data" package makes those test tunes work. Since a few users have asked about such silent sids before in upstream tracker, I will contact upstream about whether it is known how much exactly is missing (e.g. just default IRQ handlers in kernal space or larger parts?).


* Untested: The "Songlength Database" which is also touched by one of the patches. I dunno what may have changed over the past years, whether it works and whether it is still updated.


> make install DESTDIR=$RPM_BUILD_ROOT

Just for the record, nowadays there's %make_install for that.


* Other than that, I see no packaging mistakes.

APPROVED

(In reply to comment #1)
> * Untested: The "Songlength Database" which is also touched by one of the
> patches. I dunno what may have changed over the past years, whether it works
> and whether it is still updated.

I've tested this and it works :)  The patch is only so that the Songlenghts.txt file can be optionally put under /usr/share/sidplayfp, so that it is available for all users, rather then each user needing to put it in ~/.local/share/sidplayfp separately. Also it has been send upstream and accepted there.

> > make install DESTDIR=$RPM_BUILD_ROOT
> 
> Just for the record, nowadays there's %make_install for that.

I know, but whomever came up with that should have given it a better name, this is way too much like the bad %makeinstall, so I prefer the old way.

> APPROVED

Thanks for the review!

New Package SCM Request
=======================
Package Name: sidplayfp
Short Description: SID chip music module player
Owners: jwrdegoede
Branches: f17 f18 f19
InitialCC: mschwendt

Git done (by process-git-requests).

libsidplayfp-1.0.1-2.fc19,sidplayfp-1.0.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/libsidplayfp-1.0.1-2.fc19,sidplayfp-1.0.1-1.fc19

libsidplayfp-1.0.1-2.fc18,sidplayfp-1.0.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/libsidplayfp-1.0.1-2.fc18,sidplayfp-1.0.1-1.fc18

libsidplayfp-1.0.1-2.fc17,sidplayfp-1.0.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/libsidplayfp-1.0.1-2.fc17,sidplayfp-1.0.1-1.fc17

libsidplayfp-1.0.1-2.fc19, sidplayfp-1.0.1-1.fc19 has been pushed to the Fedora 19 testing repository.

libsidplayfp-1.0.1-2.fc19, sidplayfp-1.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.

libsidplayfp-1.0.1-2.fc18, sidplayfp-1.0.1-1.fc18 has been pushed to the Fedora 18 stable repository.

libsidplayfp-1.0.1-2.fc17, sidplayfp-1.0.1-1.fc17 has been pushed to the Fedora 17 stable repository.