Bug 951873
Summary: | Review Request: perl-DBD-InterBase - An InterBase and Firebird interface for perl | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
Component: | Package Review | Assignee: | Petr Šabata <psabata> |
Status: | CLOSED WORKSFORME | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | mapopa, package-review, psabata |
Target Milestone: | --- | Flags: | psabata:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-12-08 23:22:08 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 182235 |
Description
Robert Scheck
2013-04-14 01:03:45 UTC
Taking the review. Please, submit perl-DBD-InterBase-0.48-perl_514.patch upstream if you haven't already (I can't see it listed on RT). More people could benefit from this. %defattr is not required (not even in EPEL) and could be dropped. The same probably applies to line 39 but I'm not sure about it; please check. You're missing some build-time deps: perl(Carp), ./InterBase.pm:14, ./InterBase.pm:135 perl(Data::Dumper), t/31prepare.t:8, t/91txinfo.t:8 perl(Exporter), ./InterBase.pm:18, lib/DBD/InterBase/TypeInfo.pm:16 perl(threads), t/80event-ithreads.t:103 (recommended) (+ Config, DynaLoader, POSIX, strict, and vars -- those don't dual-live yet but might in the future; it's up to you) I'm not sure about the license of this package, quoting: You may distribute under the terms of either the GNU General Public License or the Artistic License, as specified in the Perl README file, with the exception that it cannot be placed on a CD-ROM or similar media for commercial distribution without the prior approval of the author. I'll ask fedora-legal if such exception is alright in our case. (In reply to comment #2) > I'll ask fedora-legal if such exception is alright in our case. "Not acceptable, unless that exception clause is waived/removed." Please, resolve with upstream. Petr, thank you for discovering this. Interestingly this clause is only in the source code, not in the README file. I have sent a message to upstream to get this (hopefully) solved soon. DBD-InterBase is unmaintained and is replaced with DBD-Firebird for perl Firebird development http://search.cpan.org/~dam/DBD-Firebird-1.16/ Unfortunately perl-DBD-InterBase is needed for the old Firebird in EPEL 5 as DBD-Firebird expects a newer Firebird than EPEL 5 is providing. Meanwhile I have migrated my last RHEL 5 with Firebird and Perl to RHEL 6, so this is no longer relevant for me - closing hereby unsuccessfully. If anybody is in the future looking to this: Upstream did not solve the licensing issue, I am still waiting on a reply. |