Bug 951951
| Summary: | iscsi.service should not run on systems without iSCSI | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Flóki Pálsson <flokip> |
| Component: | iscsi | Assignee: | Chris Leech <cleech> |
| Status: | CLOSED ERRATA | QA Contact: | Brock Organ <borgan> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 19 | CC: | awilliam, BobLfoot, ignatenko, robatino, tomek, vbocek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | iscsi-initiator-utils-6.2.0.873-6.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-06-01 03:12:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 834090, 963210 | ||
Seeing this bug still in 19-Beta-TC3 -- output of systemctl status iscsi.service follows:
iscsi.service - Login and scanning of iSCSI devices
Loaded: loaded (/usr/lib/systemd/system/iscsi.service; enabled)
Active: failed (Result: exit-code) since Sun 2013-05-05 14:53:53 EDT; 13min ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Process: 907 ExecStart=/sbin/iscsiadm -m node --loginall=automatic (code=exited, status=21)
Process: 893 ExecStart=/usr/libexec/iscsi_mark_root_nodes (code=exited, status=0/SUCCESS)
May 05 14:53:53 localhost.localdomain systemd[1]: Starting Login and scanning of iSCSI devices...
May 05 14:53:53 localhost.localdomain iscsiadm[907]: iscsiadm: No records found
May 05 14:53:53 localhost.localdomain systemd[1]: iscsi.service: main process exited, code=exited, status=21/n/a
May 05 14:53:53 localhost.localdomain systemd[1]: Failed to start Login and scanning of iSCSI devices.
May 05 14:53:53 localhost.localdomain systemd[1]: MESSAGE=Unit iscsi.service entered failed state.
$ systemctl status iscsi
iscsi.service - Login and scanning of iSCSI devices
Loaded: loaded (/usr/lib/systemd/system/iscsi.service; enabled)
Active: failed (Result: exit-code) since Wed 2013-05-15 08:17:19 MSK; 1h 45min ago
Docs: man:iscsid(8)
man:iscsiadm(8)
Main PID: 1106 (code=exited, status=21)
CGroup: name=systemd:/system/iscsi.service
May 15 08:17:19 ThinkPad-X230.localdomain systemd[1]: iscsi.service: main process exited, code=exited, status=21/n/a
May 15 08:17:19 ThinkPad-X230.localdomain systemd[1]: Failed to start Login and scanning of iSCSI devices.
May 15 08:17:19 ThinkPad-X230.localdomain systemd[1]: Unit iscsi.service entered failed state.
I think iscsi.service should have ConditionDirectoryNotEmpty=/var/lib/iscsi/nodes I'm not sure thought - some iSCSI expert should check if there is a valid use scenario with empty "nodes" directory. (In reply to Tomasz Torcz from comment #3) > I think iscsi.service should have > ConditionDirectoryNotEmpty=/var/lib/iscsi/nodes > I'm not sure thought - some iSCSI expert should check if there is a valid > use scenario with empty "nodes" directory. That works, and it makes more sense then the conditional on /etc/iscsi/initiatorname.iscsi here. I'll go ahead and make this change, thanks. iscsi-initiator-utils-6.2.0.873-6.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/iscsi-initiator-utils-6.2.0.873-6.fc19 Tested by building a live image including this build, and indeed iscsi.service now fails to try and start, with 'start condition failed', which is what I'd expect. I don't have an iSCSI setup here at present so I can't confirm that iSCSI installs still work OK with the updated package, though. I really need to spend a few minutes to set up an iSCSI drive on my NAS... iscsi-initiator-utils-6.2.0.873-6.fc19 tested on machine without iscsi, it properly disables itself with "start condition failed". Package iscsi-initiator-utils-6.2.0.873-6.fc19: * should fix your issue, * was pushed to the Fedora 19 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing iscsi-initiator-utils-6.2.0.873-6.fc19' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-9530/iscsi-initiator-utils-6.2.0.873-6.fc19 then log in and leave karma (feedback). iscsi-initiator-utils-6.2.0.873-6.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: systemctl status iscsi shows failed status. Installed F19 Fedora-Live-Desktop-x86_64-19-Alpha-TC5-1.iso. Updated. Version-Release number of selected component (if applicable): $ rpm -qa | grep iscsi iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64 libiscsi-1.7.0-3.fc19.x86_64 $ How reproducible: Always Steps to Reproduce: 1. $ systemctl status iscsi 2. 3. Actual results: $ systemctl status iscsi iscsi.service - Login and scanning of iSCSI devices Loaded: loaded (/usr/lib/systemd/system/iscsi.service; enabled) Active: failed (Result: exit-code) since sun 2013-04-14 17:25:07 GMT; 25min ago Docs: man:iscsid(8) man:iscsiadm(8) Process: 2083 ExecStart=/sbin/iscsiadm -m node --loginall=automatic (code=exited, status=21) Process: 2067 ExecStart=/usr/libexec/iscsi_mark_root_nodes (code=exited, status=0/SUCCESS) [floki@localhost ~]$ Expected results: Not failed. Additional info: $ systemctl --all --failed UNIT LOAD ACTIVE SUB DESCRIPTION iscsi.service loaded failed failed Login and scanning of iSCSI devices nfs-mountd.service loaded failed failed NFS Mount Daemon rngd.service loaded failed failed Hardware RNG Entropy Gatherer Daemon LOAD = Reflects whether the unit definition was properly loaded. ACTIVE = The high-level unit activation state, i.e. generalization of SUB. SUB = The low-level unit activation state, values depend on unit type. 3 loaded units listed. To show all installed unit files use 'systemctl list-unit-files'. [floki@localhost ~]$