Bug 953111

Summary:	shell syntax in default environment file /etc/sysconfig/sshd
Product:	[Fedora] Fedora	Reporter:	Michal Schmidt <mschmidt>
Component:	openssh	Assignee:	Petr Lautrbach <plautrba>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	18	CC:	mattias.ellert, mgrepl, plautrba, tmraz
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-04-26 00:57:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michal Schmidt 2013-04-17 11:51:13 UTC

Description of problem:
/etc/sysconfig/sshd contains this line:
export SSH_USE_STRONG_RNG=0

The file is used as EnvironmentFile in the systemd unit file sshd.service. systemd environment files are not shell scripts. systemd does not understand the "export" keyword. systemd treats it as an assignment to the key "export SSH_USE_STRONG_RNG", which is an invalid key name, so it's thrown away.

Version-Release number of selected component (if applicable):
openssh-6.1p1-6.fc18.x86_64

How reproducible:
always

Steps to Reproduce:
1. Start sshd.service with the default configuration.
2. xxd /proc/$(pidof sshd)/environ
  
Actual results:
See that SSH_USE_STRONG_RNG is not present in the process's environment.

Expected results:
I actually do not think that setting environment variables is the best way to configure services. I would very much prefer if there were an option called UseStrongRNG somewhere in /etc/ssh/.

Comment 1 Petr Lautrbach 2013-04-17 14:53:51 UTC

good catch, thanks

> Expected results:
> I actually do not think that setting environment variables is the best way
> to configure services. I would very much prefer if there were an option
> called UseStrongRNG somewhere in /etc/ssh/.

The environment variable is used also in ssh client, ssh-keygen, ssh-keysign ... so this kind of configuration is same among all parts of openssh.

Comment 2 Fedora Update System 2013-04-17 15:48:33 UTC

openssh-6.2p1-4.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/openssh-6.2p1-4.fc19

Comment 3 Fedora Update System 2013-04-17 16:19:32 UTC

openssh-6.1p1-7.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/openssh-6.1p1-7.fc18

Comment 4 Fedora Update System 2013-04-18 02:28:35 UTC

Package openssh-6.1p1-7.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing openssh-6.1p1-7.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-5918/openssh-6.1p1-7.fc18
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2013-04-23 03:40:08 UTC

openssh-6.2p1-4.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Fedora Update System 2013-04-26 00:57:19 UTC

openssh-6.1p1-8.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.