Bug 954148

Summary: Review Request: mingw-enet - Thin, simple and robust network layer on top of UDP
Product: [Fedora] Fedora Reporter: Marcel Wysocki <maci>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-mingw, itamar, maci, package-review, valtri
Target Milestone: ---Flags: maci: needinfo-
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-20 01:37:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449    
Attachments:
Description Flags
linker flags to produce shared library none

Description Marcel Wysocki 2013-04-21 09:19:39 UTC
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/mingw-enet.spec
SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/mingw-enet-1.3.3-1.fc18.src.rpm
Description: Thin, simple and robust network layer on top of UDP
Fedora Account System Username: maci

Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=5284325

Comment 1 František Dvořák 2013-10-09 08:41:24 UTC
Created attachment 809759 [details]
linker flags to produce shared library

MinGW ports need always -no-undefined flag when linking a library. The hacks in the specfile can be replaced by this patch (with added dependency on automake).

The --output-def in the patch is not needed, it's just the producing .def and packaging it could be useful.

Incorporating this to upstream would require some more work on "autostuff" - to enable flags in configure only for MinGW builds.

Comment 2 František Dvořák 2016-03-19 22:22:12 UTC
This review looks like stalled and can be closed within week according to https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews .

Comment 3 Itamar Reis Peixoto 2016-03-20 01:37:59 UTC
please reopen if you're still interested, thank you.