Bug 954331

Summary: beanstalkd package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: beanstalkdAssignee: Jeremy Hinegardner <jeremy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, jeremy
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: beanstalkd-1.9-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-21 08:34:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
this should enable PIE none

Description Dhiru Kholia 2013-04-22 10:22:46 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently beanstalkd is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

beanstalkd-1.4.6-8.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py beanstalkd-1.4.6-8.fc19.x86_64.rpm
beanstalkd,beanstalkd-1.4.6-8.fc19.x86_64.rpm,/usr/bin/beanstalkd,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 1 Dhiru Kholia 2013-04-30 07:53:40 UTC 
Created attachment 741786 [details]
this should enable PIE
Comment 2 Dhiru Kholia 2013-04-30 07:55:26 UTC 
Dear (lazy / busy) maintainer,

For enabling PIE I have uploaded a patch + modified .spec file at https://github.com/kholia/unSPEC/tree/master/beanstalkd

That link also has a small benchmarking script (bench.py).

In my limited testing, I couldn't find any performance difference between 
the PIE and no-PIE builds.
Comment 3 Dhiru Kholia 2013-06-26 12:11:18 UTC 
Do the attached patches work?
Comment 4 Jeremy Hinegardner 2013-06-28 16:37:12 UTC 
My apologies, I'll be spending a day next week on Fedora items.
Comment 5 Jeremy Hinegardner 2013-09-09 00:30:24 UTC 
This will be fixed in the next build

$ rpm-chksec beanstalkd
FILE                                                     TYPE        RELRO    PIE
/usr/bin/beanstalkd                                      daemon      full     yes
Comment 6 Fedora Update System 2013-09-09 06:07:23 UTC 
beanstalkd-1.9-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beanstalkd-1.9-1.fc20
Comment 7 Fedora Update System 2013-09-09 06:07:37 UTC 
beanstalkd-1.9-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/beanstalkd-1.9-1.fc19
Comment 8 Fedora Update System 2013-09-09 16:18:29 UTC 
Package beanstalkd-1.9-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beanstalkd-1.9-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-16126/beanstalkd-1.9-1.fc20
then log in and leave karma (feedback).
Comment 9 Fedora Update System 2013-09-21 08:34:30 UTC 
beanstalkd-1.9-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 10 Fedora Update System 2013-09-23 00:19:51 UTC 
beanstalkd-1.9-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.