Bug 954347

Summary: dropbear package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: dropbearAssignee: Christopher Meng <i>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, buytenh, i, itamar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-18 02:02:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 892837    
Bug Blocks:    
Attachments:
Description Flags
this should enable PIE none

Description Dhiru Kholia 2013-04-22 10:56:12 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently dropbear is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

dropbear-0.55-5.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py dropbear-0.55-5.fc19.x86_64.rpm
dropbear,dropbear-0.55-5.fc19.x86_64.rpm,/usr/bin/dbclient,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
dropbear,dropbear-0.55-5.fc19.x86_64.rpm,/usr/bin/dropbearconvert,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
dropbear,dropbear-0.55-5.fc19.x86_64.rpm,/usr/bin/dropbearkey,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
dropbear,dropbear-0.55-5.fc19.x86_64.rpm,/usr/sbin/dropbear,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 1 Dhiru Kholia 2013-05-14 11:00:15 UTC 
Created attachment 747643 [details]
this should enable PIE
Comment 2 Christopher Meng 2013-05-16 09:40:48 UTC 
(In reply to comment #1)
> Created attachment 747643 [details]
> this should enable PIE

Hi,

Like https://bugzilla.redhat.com/show_bug.cgi?id=955147

After hardenbuild koji failed with such logs:

http://koji.fedoraproject.org/koji/getfile?taskID=5387032&name=build.log

I cannot add PIE flag now.
Comment 3 Dhiru Kholia 2013-05-16 10:26:34 UTC 
Christopher,

Please see https://bugzilla.redhat.com/show_bug.cgi?id=892837 (and upvote the fix for #892837).
Comment 4 Christopher Meng 2013-05-18 02:02:55 UTC 
http://koji.fedoraproject.org/koji/taskinfo?taskID=5394334