Bug 954365 (CVE-2013-3221)
| Summary: | CVE-2013-3221 rubygem-activerecord: Data-type injection attacks due absent database column data type (input vs stored value) check | ||
|---|---|---|---|
| Product: | [Other] Security Response | Reporter: | Jan Lieskovsky <jlieskov> |
| Component: | vulnerability | Assignee: | Red Hat Product Security <security-response-team> |
| Status: | CLOSED NOTABUG | QA Contact: | |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | unspecified | CC: | bkabrda, bkearney, bleanhar, ccoleman, cpelland, dajohnso, dmcphers, jeckersb, jialiu, jomara, katello-bugs, katello-internal, lmeyer, mastahnke, mmccune, mmorsi, morazi, msuchy, mtasaka, sclewis, sseago, tkramer, vanmeeuwen+fedora, vondruch |
| Target Milestone: | --- | Keywords: | Security |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-17 19:23:04 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 954370 | ||
|
Description
Jan Lieskovsky
2013-04-22 11:44:02 UTC
Issue related information from Novell #816666 bug: -------------------------------------------------- "1. this is a bug in MySQL. *not* rails! *every* other language using mysql is also affected. 2. this is mitigated in https://github.com/rails/rails/commit/921a296a3390192a71abeec6d9a035cc6d1865c8 which is part of rails 3.2.12. I havent checked older branches. 3. you should force MySQL to disallow the type casting feature." Another clarification due this from Mitre: http://www.openwall.com/lists/oss-security/2013/04/24/7 This isn't something that can necessarily be fixed:
Fixes
- -----
Unfortunately it is not possible for ActiveRecord to automatically
protect against all instances of this attack due to the API we expose.
For example:
User.where("login_token = ? AND expires_at > ?", params[:token],
Time.now)
Without parsing the SQL fragments it is not possible to determine what
type params[:token] should be cast to.
Future releases of Rails will contain changes to mitigate the risk of
this class of vulnerability, however as long as this feature is still
supported this risk will remain.
As per comment 4, this issue cannot be directly addressed in rubygem-activerecord or MySQL as the issue is in the intersection of these two applications due to type handling. Without a major restructuring of how data is handled within rubygem-activerecord or MySQL it is up to developers to write applications safely: As mentioned in the original advisory (http://openwall.com/lists/oss-security/2013/02/06/7): There are two options to avoid these problems. The first is to disable JSON and XML parameter parsing. Depending on the version of rails you use you will have to place one of the following snippets in an application initializer Rails 3.2, 3.1 and 3.0: ActionDispatch::ParamsParser::DEFAULT_PARSERS.delete(Mime::XML) ActionDispatch::ParamsParser::DEFAULT_PARSERS.delete(Mime::JSON) Rails 2.3: ActionController::Base.param_parsers.delete(Mime::XML) ActionController::Base.param_parsers.delete(Mime::JSON) If your application relies on accepting these formats you will have to take care to explicitly convert parameters to their intended types. For example: User.where(:login_token=>params[:token].to_s) Statement CVE-2013-3221: Not a security issue. This issue is due to the handling of data types when passing data between rubygem-activerecord and MySQL. Applications that use rubygem-activerecord and MySQL may be affected if written in a way that exposes the issue, however any flaw would be specific to that application. For further information, please refer to https://bugzilla.redhat.com/show_bug.cgi?id=954365#c5 |