Bug 955167

Summary: iscsi-initiator-utils package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: iscsi-initiator-utilsAssignee: Chris Leech <cleech>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: agrover, bressers, cleech, hdegoede
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: iscsi-initiator-utils-6.2.0.873-7.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-06-29 18:20:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
this should enable PIE none

Description Dhiru Kholia 2013-04-22 13:43:26 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently iscsi-initiator-utils is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm
iscsi-initiator-utils,iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm,/sbin/iscsi-iname,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
iscsi-initiator-utils,iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm,/sbin/iscsiadm,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
iscsi-initiator-utils,iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm,/sbin/iscsid,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
iscsi-initiator-utils,iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm,/sbin/iscsistart,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
iscsi-initiator-utils,iscsi-initiator-utils-6.2.0.873-4.fc19.x86_64.rpm,/sbin/iscsiuio,NX=Enabled,CANARY=Disabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Disabled,CATEGORY=network-local

Comment 1 Dhiru Kholia 2013-05-17 04:32:35 UTC
Created attachment 749166 [details]
this should enable PIE

Comment 2 Dhiru Kholia 2013-06-03 06:10:17 UTC
Hi,

Is there any progress on this?

Does the attached modified .spec file works?

Comment 3 Fedora Update System 2013-06-12 22:40:41 UTC
iscsi-initiator-utils-6.2.0.873-7.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/iscsi-initiator-utils-6.2.0.873-7.fc19

Comment 4 Fedora Update System 2013-06-13 18:06:18 UTC
Package iscsi-initiator-utils-6.2.0.873-7.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing iscsi-initiator-utils-6.2.0.873-7.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-10771/iscsi-initiator-utils-6.2.0.873-7.fc19
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2013-06-29 18:20:54 UTC
iscsi-initiator-utils-6.2.0.873-7.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.