Bug 955206

Summary: tigervnc package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: tigervncAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bphinz, bressers, dhiru, ovasik, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tigervnc-1.3.1-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-27 15:23:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1063392    
Bug Blocks:    
Attachments:
Description Flags
patch to enable PIE none

Description Dhiru Kholia 2013-04-22 14:30:36 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently tigervnc is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

tigervnc-server-1.2.80-0.12.20130314svn5065.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py tigervnc-server-1.2.80-0.12.20130314svn5065.fc19.x86_64.rpm
tigervnc-server,tigervnc-server-1.2.80-0.12.20130314svn5065.fc19.x86_64.rpm,/usr/bin/x0vncserver,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 2 Fedora Admin XMLRPC Client 2013-05-13 14:53:52 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 3 Dhiru Kholia 2013-12-20 07:35:44 UTC 
Created attachment 839426 [details]
patch to enable PIE
Comment 4 Dhiru Kholia 2013-12-20 07:37:00 UTC 
Hi Tim,

Can you please test the attached patch?
Comment 5 Tim Waugh 2014-01-13 15:25:34 UTC 
Thanks, I will. I haven't forgotten it.