Bug 955282

Summary: gogoc package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: gogocAssignee: Juan Orti <jorti>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, jorti
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-03 23:58:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
this should enable PIE none

Description Dhiru Kholia 2013-04-22 17:16:54 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently gogoc is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

gogoc-1.2-23.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py gogoc-1.2-23.fc19.x86_64.rpm
gogoc,gogoc-1.2-23.fc19.x86_64.rpm,/usr/bin/gogoc,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 1 Juan Orti 2013-04-22 20:19:08 UTC 
This package is already built with the macro _hardened_build

An example from the build log:
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -O2 -Wall ...

I think "-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1" does the -fPIE compiling, right?

Can be something wrong in your script? I will give it a look in more detail tomorrow.
Comment 2 Dhiru Kholia 2013-04-25 10:14:26 UTC 
Created attachment 739803 [details]
this should enable PIE
Comment 3 Fedora Update System 2013-04-25 11:26:30 UTC 
gogoc-1.2-24.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gogoc-1.2-24.fc18
Comment 4 Juan Orti 2013-04-25 18:35:13 UTC 
(In reply to comment #2)
> Created attachment 739803 [details]
> this should enable PIE

You are right.
I have submitted an update with the fix, now the security analysis gives this output:

Analyzing gogoc-1.2-24.fc18.x86_64.rpm ...
gogoc,gogoc-1.2-24.fc18.x86_64.rpm,/usr/bin/gogoc,NX=Enabled,CANARY=Enabled,RELRO=Enabled,PIE=Enabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 5 Fedora Update System 2013-04-26 01:04:54 UTC 
Package gogoc-1.2-24.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing gogoc-1.2-24.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-6656/gogoc-1.2-24.fc18
then log in and leave karma (feedback).
Comment 6 Fedora Update System 2013-05-03 23:58:38 UTC 
gogoc-1.2-24.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2013-05-07 10:25:50 UTC 
gogoc-1.2-24.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gogoc-1.2-24.fc19
Comment 8 Fedora Update System 2013-05-12 04:53:09 UTC 
gogoc-1.2-24.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.