Bug 955317

Summary: mt-daapd package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: mt-daapdAssignee: Jean-Francois Saucier <jsaucier>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, jsaucier
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mt-daapd-0.2.4.2-17.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-22 00:45:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
this should enable PIE none

Description Dhiru Kholia 2013-04-22 18:43:59 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently mt-daapd is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

mt-daapd-0.2.4.2-14.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py mt-daapd-0.2.4.2-14.fc19.x86_64.rpm
mt-daapd,mt-daapd-0.2.4.2-14.fc19.x86_64.rpm,/usr/sbin/mt-daapd,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 1 Dhiru Kholia 2013-05-17 05:29:11 UTC 
Created attachment 749188 [details]
this should enable PIE
Comment 2 Dhiru Kholia 2013-06-03 06:12:59 UTC 
Hi,

Is there any progress on this?

Does the attached modified .spec file works?
Comment 3 Fedora Update System 2013-08-07 17:17:53 UTC 
mt-daapd-0.2.4.2-17.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/mt-daapd-0.2.4.2-17.fc19
Comment 4 Fedora Update System 2013-08-07 17:26:42 UTC 
mt-daapd-0.2.4.2-17.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mt-daapd-0.2.4.2-17.fc18
Comment 5 Fedora Update System 2013-08-09 17:08:14 UTC 
Package mt-daapd-0.2.4.2-17.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mt-daapd-0.2.4.2-17.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-14499/mt-daapd-0.2.4.2-17.fc18
then log in and leave karma (feedback).
Comment 6 Fedora Update System 2013-08-22 00:45:25 UTC 
mt-daapd-0.2.4.2-17.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2013-08-22 00:51:02 UTC 
mt-daapd-0.2.4.2-17.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.