Bug 955451

Summary: tabled package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: tabledAssignee: Jeff Garzik <jgarzik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, jgarzik, peterm, zaitcev
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tabled-0.5.2-2.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-24 00:41:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dhiru Kholia 2013-04-23 05:21:32 UTC
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently tabled is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

tabled-0.5.1-0.5.g33595340.fc18.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py tabled-0.5.1-0.5.g33595340.fc18.x86_64.rpm
tabled,tabled-0.5.1-0.5.g33595340.fc18.x86_64.rpm,/usr/sbin/tabled,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
tabled,tabled-0.5.1-0.5.g33595340.fc18.x86_64.rpm,/usr/sbin/tdbadm,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None

Comment 1 Pete Zaitcev 2013-04-24 00:41:17 UTC
Fixed in tabled-0.5.2-2.fc20.

Comment 2 Dhiru Kholia 2013-05-06 06:09:06 UTC
Pete,

Will F19 get the fixed version as well?

Comment 3 Pete Zaitcev 2013-05-06 15:04:32 UTC
Do we really need it? The package has no users, I just keep it around
so we can pilfer useful code from it (for e.g. Openstack swift-oserver).
I suppose I could...

Comment 4 Pete Zaitcev 2013-05-06 15:55:34 UTC
Oh what the heck, have tabled-0.5.2-2.fc19. Pushing to Bodhi.

Comment 5 Fedora Update System 2013-05-06 15:59:09 UTC
tabled-0.5.2-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/tabled-0.5.2-2.fc19

Comment 6 Fedora Update System 2013-09-13 01:11:57 UTC
tabled-0.5.2-2.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.