Bug 955459

Summary: redis package should be built with PIE flags
Product: [Fedora] Fedora Reporter: Dhiru Kholia <dkholia>
Component: redisAssignee: Silas Sewell <silas>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: bressers, fabian.deutsch, silas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: redis-2.6.16-1.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-23 00:50:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
this should enable PIE
none
this should enable PIE none

Description Dhiru Kholia 2013-04-23 05:32:09 UTC 
Description of problem:

http://fedoraproject.org/wiki/Packaging:Guidelines#PIE says that "you MUST
enable the PIE compiler flags if your package is long running ...".

However, currently redis is not being built with PIE flags. This is a
clear violation of the packaging guidelines.

This issue (in its wider scope) is being discussed at,

https://fedorahosted.org/fesco/ticket/1104

https://lists.fedoraproject.org/pipermail/devel/2013-March/180827.html

Version-Release number of selected component (if applicable):

redis-2.6.7-2.fc19.x86_64.rpm

How reproducible:

You can use following programs to check if a package is hardened:

http://people.redhat.com/sgrubb/files/rpm-chksec

OR

https://github.com/kholia/checksec

Steps to Reproduce:

Get scanner.py from https://github.com/kholia/checksec

$ ./scanner.py redis-2.6.7-2.fc19.x86_64.rpm
redis,redis-2.6.7-2.fc19.x86_64.rpm,/usr/bin/redis-benchmark,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
redis,redis-2.6.7-2.fc19.x86_64.rpm,/usr/bin/redis-check-aof,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
redis,redis-2.6.7-2.fc19.x86_64.rpm,/usr/bin/redis-check-dump,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=None
redis,redis-2.6.7-2.fc19.x86_64.rpm,/usr/bin/redis-cli,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
redis,redis-2.6.7-2.fc19.x86_64.rpm,/usr/sbin/redis-server,NX=Enabled,CANARY=Enabled,RELRO=Partial,PIE=Disabled,RPATH=Disabled,RUNPATH=Disabled,FORTIFY=Enabled,CATEGORY=network-ip
Comment 1 Dhiru Kholia 2013-05-14 05:57:37 UTC 
Created attachment 747519 [details]
this should enable PIE
Comment 2 Dhiru Kholia 2013-05-14 05:58:05 UTC 
Created attachment 747520 [details]
this should enable PIE
Comment 3 Dhiru Kholia 2013-05-14 06:57:01 UTC 
In my limited testing, I couldn't find any performance difference between 
the PIE and no-PIE builds.

The benchmarking script is at https://github.com/kholia/unSPEC/blob/master/redis/redis_bench.py
Comment 4 Fedora Update System 2013-06-07 07:42:34 UTC 
redis-2.6.13-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/redis-2.6.13-2.fc19
Comment 5 Fedora Update System 2013-06-07 07:42:56 UTC 
redis-2.6.13-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/redis-2.6.13-2.fc18
Comment 6 Fedora Update System 2013-06-07 15:38:10 UTC 
Package redis-2.6.13-2.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing redis-2.6.13-2.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-10264/redis-2.6.13-2.fc19
then log in and leave karma (feedback).
Comment 7 Fedora Update System 2013-09-06 10:21:15 UTC 
redis-2.6.16-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/redis-2.6.16-1.fc19
Comment 8 Fedora Update System 2013-09-06 10:21:50 UTC 
redis-2.6.16-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/redis-2.6.16-1.fc20
Comment 9 Fedora Update System 2013-09-06 10:22:27 UTC 
redis-2.6.16-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/redis-2.6.16-1.fc18
Comment 10 Fedora Update System 2013-09-23 00:50:41 UTC 
redis-2.6.16-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 11 Fedora Update System 2013-09-30 00:30:41 UTC 
redis-2.6.16-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 12 Fedora Update System 2013-11-02 04:54:52 UTC 
redis-2.6.16-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.