Bug 955651

Summary: help(Gtk) segfaults
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: pygobject3Assignee: John (J5) Palmieri <john.j5live>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 19CC: bkabrda, dmalcolm, icq, ivazqueznet, john.j5live, jonathansteffan, tomspur
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-18 13:52:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
backtrace
none
Fixes segfault on calling help(Gtk) interactively none

Description Jiri Popelka 2013-04-23 13:15:56 UTC
Created attachment 738997 [details]
backtrace

Version-Release number of selected component (if applicable):
python-2.7.4-3.fc19.x86_64
gtk3-3.8.1-1.fc19.x86_64

Steps to Reproduce:
1. python
2. from gi.repository import Gtk
3. help(Gtk)
4. press q
  
Actual results:
Segmentation fault (core dumped)

Comment 1 Bohuslav "Slavek" Kabrda 2013-04-25 08:45:35 UTC
Notes:
There is a related package pygobject3, that provides the "gi" module, F19 currently has:
pygobject3-3.8.1-1.fc20.x86_64

It seems that help for classes of Gtk module, that is constructed in pydoc.py TextDoc.docmodule#1096 (if classes: ...) is producing a corrupt string. When the segfault occurs, len(result) is always 8245286, but sometimes the segfault doesn't occur and then len(result) is 8245085. I'll try to find out whether this is a bug on Python side or bad construction of the docstring on side of pygobject3.

Comment 2 Bohuslav "Slavek" Kabrda 2013-04-25 10:35:04 UTC
This is the commit that introduces the issue:

https://git.gnome.org/browse/pygobject/commit/gi/types.py?id=13629f5a9c9a7022f3521a3616d9ce8fa4a6161b

Reverting it makes help(Gtk) pass. It may still be a bug in Python, though.

Comment 3 Bohuslav "Slavek" Kabrda 2013-04-25 11:18:27 UTC
Since I was able to reproduce it with Python 2.7.3, too, I reported bug for pygobject3 upstream: https://bugzilla.gnome.org/show_bug.cgi?id=698829. Let's wait and see what they say about it.

Comment 4 Bohuslav "Slavek" Kabrda 2013-04-25 12:58:45 UTC
Created attachment 739880 [details]
Fixes segfault on calling help(Gtk) interactively

So the upstream has provided patch that works for me. I'm attaching a patch that can be applied directly into dist-git (although the tests are failing for me when rebuilding - with or without the new patch...)

Comment 5 Bohuslav "Slavek" Kabrda 2013-04-25 13:00:10 UTC
Reassigning to pygobject3 maintainer. Could you please apply the patch to fix this issue?
Thanks.

Comment 6 Fedora End Of Life 2015-01-09 22:06:14 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Fedora End Of Life 2015-02-18 13:52:35 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.