Bug 956506

Summary: virsh snapshot-delete --children-only bypasses safety check for deleting disk-only children
Product: Red Hat Enterprise Linux 7 Reporter: tingting zheng <tzheng>
Component: libvirtAssignee: Eric Blake <eblake>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.0CC: cwei, dyuan, eblake, honzhang, jsuchane, mzhan, rbalakri, shyu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-1.2.8-6.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 903052
: 1134674 (view as bug list) Environment:
Last Closed: 2015-03-05 07:20:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 903052    
Bug Blocks: 1113520, 1134674    

Comment 2 Eric Blake 2013-06-06 02:58:31 UTC
Still needs fixing upstream, but should be relatively easy to reproduce and thus locate the bug.

Comment 4 Eric Blake 2013-07-10 20:59:37 UTC
Right now, libvirt documents that it refuses to delete external snapshots only because it is not implemented safely; this bug represents a hole where we aren't following the documentation.  Alternatives are to patch code to match docs (quick), or to actually implement snapshot deletion (longer, but more desirable).  I see no need to do a quick patch now only to undo it later when true snapshot deletion is implemented.

Comment 6 Eric Blake 2014-10-27 11:45:17 UTC
Upstream proposed patch:
https://www.redhat.com/archives/libvir-list/2014-October/msg00823.html

Comment 9 Shanzhi Yu 2014-11-14 09:19:42 UTC
Change to VERIFIED status. Steps as below:

# virsh snapshot-create-as rh7 internal
Domain snapshot internal created
# virsh snapshot-create-as rh7 external --disk-only
Domain snapshot external created
# virsh snapshot-delete rh7 internal --children
error: Failed to delete snapshot internal
error: unsupported configuration: deletion of 1 external disk snapshots not supported yet
# virsh snapshot-delete rh7 internal --children-only 
error: Failed to delete snapshot internal
error: unsupported configuration: deletion of 1 external disk snapshots not supported yet

Comment 11 errata-xmlrpc 2015-03-05 07:20:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-0323.html