Bug 956562

Summary: New Data Center dialog box get closed when same name exists in the engine already
Product: Red Hat Enterprise Virtualization Manager Reporter: Maor <mlipchuk>
Component: ovirt-engineAssignee: Alexander Wels <awels>
Status: CLOSED CURRENTRELEASE QA Contact: Petr Matyáš <pmatyas>
Severity: low Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: bazulay, bsettle, gklein, lsurette, mgoldboi, rbalakri, Rhev-m-bugs, srevivo, ykaul
Target Milestone: ovirt-3.6.0-rc   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-04-20 01:31:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
engine log none

Description Maor 2013-04-25 08:33:24 UTC 
Description of problem:
Dialog box of New Data Center, gets closed when trying to add a new DC with a name which already exists
The message indicates "Error while executing action: Cannot create Repository. Data Center name is already in use."

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.Crate a new DC with same name already exists in the setup
2.
3.
  
Actual results:
get a pop up message "Error while executing action: Cannot create Repository. Data Center name is already in use."
and close the new dialog box of new Data Ceneter


Expected results:
Dialog box should not be closed.

Additional info:
Comment 1 Maor 2013-04-25 10:12:40 UTC 
Created attachment 739794 [details]
engine log
Comment 2 Einav Cohen 2013-08-08 14:57:28 UTC 
the behavior / request described here is very similar to the one described in bug 670863.

when the error originates from the client validation, we are not closing the dialog (we will highlight the problematic field/section within the dialog)

when the error originates from the server, we are always closing the dialog.

I assume that there are some errors for which it makes sense to close the dialog, and there are other errors for which it makes sense to keep the dialog open.
the GUI is indifferent to the returned error - it doesn't have a way of knowing the correct behavior to perform upon each and ever returned error. 

solving this issue will require quite a lot of work, which I don't think we will be able to do any time soon, hence flagging for future.
Comment 3 Einav Cohen 2014-02-12 16:49:49 UTC 
update: we should introduce a validation (we have that for other business entities), this should completely eliminate this CanDoAction message to appear in the GUI.
Comment 4 Einav Cohen 2015-02-18 15:08:17 UTC 
re-assigning to Alexander.

as I mentioned in comment #3: need to introduce a Data-Center-name-uniqueness validation in the client (as exists for other New dialogs for other business entities in the system).
Comment 5 Max Kovgan 2015-06-28 14:12:23 UTC 
ovirt-3.6.0-3 release
Comment 6 Petr Matyáš 2015-07-14 11:11:03 UTC 
Verified on ovirt-engine-3.6.0-0.0.master.20150713172442.gitd6e83be.el6.noarch