Bug 956616

Summary: CLI - content definition filter: errata filter rule by id and date is inconsistent with UI
Product: Red Hat Satellite Reporter: Ales Dujicek <adujicek>
Component: HammerAssignee: David Davis <daviddavis>
Status: CLOSED CURRENTRELEASE QA Contact: Hayk Hovsepyan <hhovsepy>
Severity: medium Docs Contact:
Priority: unspecified    
Version: NightlyCC: cwelton, hhovsepy, jmontleo, mmccune, paji
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ales Dujicek 2013-04-25 10:16:04 UTC
Description of problem:

From UI you have to choose how filter errata when creating filter rule:
 -Filter Errata by Date and type
 -Errata id
but in CLI you can create rule what contains both - ids and date.
I think this should work the same way as UI.


Version-Release number of selected component (if applicable):
katello-common-1.4.1-1.git.182.8e8188f.el6.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
katello-repos-1.4.1-1.el6.noarch
katello-cli-1.4.1-1.git.182.c6940ed.el6.noarch
katello-configure-1.4.1-1.git.111.f7f9fea.el6.noarch
katello-glue-candlepin-1.4.1-1.git.182.8e8188f.el6.noarch
katello-glue-pulp-1.4.1-1.git.182.8e8188f.el6.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
katello-cli-common-1.4.1-1.git.182.c6940ed.el6.noarch
katello-selinux-1.4.1-1.el6.noarch
katello-1.4.1-1.git.182.8e8188f.el6.noarch
katello-agent-1.4.1-1.el6.noarch
katello-all-1.4.1-1.git.182.8e8188f.el6.noarch
katello-glue-elasticsearch-1.4.1-1.git.182.8e8188f.el6.noarch
katello-qpid-client-key-pair-1.0-1.noarch
katello-certs-tools-1.4.1-1.el6.noarch


How reproducible:
always

Steps to Reproduce:
1. prepare org, content definition and filter
org create --name org
content definition create --org org --name def
content definition filter create --org org --definition def --name filter
2. create rule
content definition filter add_rule --org org --definition def --name filter --content erratum --rule '{"units" : [ {"id" : "RHEA-2012:0002"} ] , "date_range" : {"start" : "2013-04-03", "end" : "2013-05-20"} }'

Comment 1 Mike McCune 2013-04-25 19:27:24 UTC
CLI will generally be a bit more flexible than the UI.  Encapsulating multiple

Comment 2 Mike McCune 2013-04-26 22:06:15 UTC
ignore previous comment, meant to say:

this causes an issue because the UI is only showing 1 of the rules even thou the specification above includes 2.

Need to either block this from the CLI or show it correctly in the webui

Comment 4 Partha Aji 2013-09-25 17:51:32 UTC
I recommend limiting the cli to say "you can either specify ids or [dates + type], but not both together". We want the rules to be as small as possible. Anyway if a user can achieve the same "or" effect by specifying 2 rules, 1 for ids and 1 for dates. Dont see value in changing UI to accomodate this.

Comment 5 Partha Aji 2013-09-25 18:34:53 UTC
As of today, the publish algorithm ignores the "date_range" and only uses the "id" information if you provide both anyway. So to me the bug is more that the CLI is malfunctioning. If in the future the "combined" functionality is desired, we could address it as a separate enhancement.

Comment 6 David Davis 2013-09-25 18:43:09 UTC
https://github.com/Katello/katello/pull/3035

Comment 7 David Davis 2013-09-26 16:57:25 UTC
Katello SHA 3e02d3eb2a336ca334540e32e70f5a888dcea33e

956616: Prevent users from filtering by id and date/type

Comment 10 Hayk Hovsepyan 2013-10-14 10:23:59 UTC
Verified on revision:
Katello-Katello-Installation-RegisterRHNClassic-1.1-4.noarch
foreman-1.3.0-17.el6sat.noarch
katello-cli-1.4.3-20.el6sat.noarch
pulp-selinux-2.3.0-0.17.beta.el6sat.noarch
openldap-2.4.23-31.el6.x86_64
apr-util-ldap-1.3.9-3.el6_0.1.x86_64
python-ldap-2.3.10-1.el6.x86_64
katello-certs-tools-1.4.4-1.el6sat.noarch
pulp-nodes-parent-2.3.0-0.17.beta.el6sat.noarch
elasticsearch-0.19.9-8.el6sat.noarch
katello-glue-candlepin-1.4.6-31.el6sat.noarch
candlepin-tomcat6-0.8.25-1.el6sam.noarch
candlepin-cert-consumer-dionysus.usersys.redhat.com-1.0-1.noarch
Katello-Katello-Installation-Satellite6Latest-1.0-12.noarch
candlepin-scl-rhino-1.7R3-1.el6_4.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
katello-qpid-client-key-pair-1.0-1.noarch
signo-0.0.22-2.el6sat.noarch
foreman-proxy-1.3.0-3.el6sat.noarch
foreman-postgresql-1.3.0-17.el6sat.noarch
katello-cli-common-1.4.3-20.el6sat.noarch
katello-configure-1.4.7-3.el6sat.noarch
pulp-server-2.3.0-0.17.beta.el6sat.noarch
pulp-nodes-common-2.3.0-0.17.beta.el6sat.noarch
pulp-puppet-plugins-2.3.0-0.17.beta.el6sat.noarch
candlepin-scl-1-5.el6_4.noarch
ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
candlepin-selinux-0.8.25-1.el6sam.noarch
signo-katello-0.0.22-2.el6sat.noarch
katello-selinux-1.4.4-4.el6sat.noarch
katello-glue-elasticsearch-1.4.6-31.el6sat.noarch
katello-1.4.6-31.el6sat.noarch
katello-configure-foreman-1.4.7-3.el6sat.noarch
katello-all-1.4.6-31.el6sat.noarch
pulp-rpm-handlers-2.3.0-0.17.beta.el6sat.noarch
katello-agent-1.4.4-3.el6sat.noarch
candlepin-scl-runtime-1-5.el6_4.noarch
katello-configure-foreman-proxy-1.4.7-3.el6sat.noarch
pulp-rpm-plugins-2.3.0-0.17.beta.el6sat.noarch
pulp-katello-plugins-0.2-1.el6sat.noarch
candlepin-scl-quartz-2.1.5-5.el6_4.noarch
candlepin-0.8.25-1.el6sam.noarch
katello-common-1.4.6-31.el6sat.noarch
katello-glue-pulp-1.4.6-31.el6sat.noarch
katello-foreman-all-1.4.6-31.el6sat.noarch
ruby193-rubygem-ldap_fluff-0.2.2-2.el6sat.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
Katello-Katello-Configuration-KatelloClient-1.1-53.noarch
Katello-Katello-Sanity-ImportKeys-1.2-1.noarch


Now it shows error message: "Validation failed: Parameters Errata rules cannot contain both id and date_range/errata_type criteria"

Comment 13 Bryan Kearney 2014-04-24 17:10:32 UTC
This was verified and delivered with MDP2. Closing it out.

Comment 14 Bryan Kearney 2014-04-24 17:11:44 UTC
This was delivered and verified with MDP2. Closing the bug.