Bug 957339
| Summary: | Review Request: openerp7 - Business Applications Server | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alec Leamas <leamas.alec> | ||||||||
| Component: | Package Review | Assignee: | Wolfgang Ulbrich <raveit65.sun> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | rawhide | CC: | raveit65.sun, rvokal | ||||||||
| Target Milestone: | --- | Flags: | raveit65.sun:
fedora-review+
kevin: fedora-cvs+ |
||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-09-24 17:13:12 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 956127, 956134 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Alec Leamas
2013-04-27 10:51:15 UTC
This is a work in progress. Whiteboard: NotReady Ready for review, clearing whiteboard, Although this is a quite complex package, it's just an update of openerp which was reviewed in bug #817271. However, this incompatible update needs a new name and thus a new review. At the time of writing, some of the dependencies are in updates-testing. rpmlint comments: openerp7.noarch: E: explicit-lib-dependency pyftpdlib This is a known bug in rpmlint, which handles any package ending in ...lib as a linkable lib. openerp7.noarch: E: non-readable /etc/openerp/openerp-server.conf 0660L This file contains a password, thus 660. openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/crm/wizard/crm_phonecall_to_opportunity.py Don't know if it's OK to remove this file, seems safest to keep. openerp7.noarch: E: zero-length .../openerp/addons/web/static/lib/datejs/globalization/tlh-TLH.js (11) These are autogenerated by the localization framework, and I hesitate to remove them. openerp7.noarch: W: log-files-without-logrotate /var/log/openerp openerp has it's own logrotate logic, so using logrotate would be messy. openerp7.noarch: W: non-standard-gid /etc/openerp openerp (4) openerp7.noarch: W: non-standard-uid /var/log/openerp openerp (2) user and group created by the package, should not be a problem. Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units You should migrate to F18+ style: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd Indeed, thanks! Updated in-place, same links. Updated, new links: spec: http://leamas.fedorapeople.org/openerp7/0/openerp7.spec srpm: http://leamas.fedorapeople.org/openerp7/0/openerp7-7.0-1.20130618_231044.fc18.src.rpm whoow, what a package.
After a first look i see only three issue in file section.
1. (double slash)
%{_unitdir}//openerp.service
2.
Replace /var with %{_localstatedir} in several places
ie.
/var/spool/openerp to
%{_localstatedir}/spool/openerp
3.
Replace '/etc' directory with %{_sysconfdir} in several places.
Detailed review comming soon.
(In reply to Wolfgang Ulbrich from comment #6) > whoow, what a package. > After a first look i see only three issue in file section. > 1. (double slash) > %{_unitdir}//openerp.service Will do. Hopefylly it's OK to wait for the full review for this minor ting?! > 2. > Replace /var with %{_localstatedir} in several places > ie. > /var/spool/openerp to > %{_localstatedir}/spool/openerp > 3. > Replace '/etc' directory with %{_sysconfdir} in several places. > 2, 3. This should actually be OK (and I find much easier to read): https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Macros (In reply to Alec Leamas from comment #7) > (In reply to Wolfgang Ulbrich from comment #6) > > whoow, what a package. > > After a first look i see only three issue in file section. > > 1. (double slash) > > %{_unitdir}//openerp.service > Will do. Hopefylly it's OK to wait for the full review for this minor ting?! > > > 2. > > Replace /var with %{_localstatedir} in several places > > ie. > > /var/spool/openerp to > > %{_localstatedir}/spool/openerp > > 3. > > Replace '/etc' directory with %{_sysconfdir} in several places. > > > > 2, 3. This should actually be OK (and I find much easier to read): > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Macros agree for 2 and 3. You should add LGPLv2+ to licence field, see attachment rpmlint.txt Checking: openerp7-7.0-1.20130618_231044.fc21.noarch.rpm openerp7-httpd-fonts-access-7.0-1.20130618_231044.fc21.noarch.rpm openerp7-7.0-1.20130618_231044.fc21.src.rpm openerp7.noarch: E: explicit-lib-dependency pyftpdlib openerp7.noarch: W: non-standard-gid /etc/openerp/openerp-server.conf openerp openerp7.noarch: E: non-readable /etc/openerp/openerp-server.conf 0660L openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/ko-KP.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/si-LK.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/ar-AR.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/bs-BS.js openerp7.noarch: W: non-standard-gid /etc/openerp openerp openerp7.noarch: W: non-standard-uid /var/run/openerp openerp openerp7.noarch: W: non-standard-gid /var/run/openerp openerp openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/sr-RS.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/tlh-TLH.js openerp7.noarch: W: non-standard-uid /var/log/openerp openerp openerp7.noarch: W: non-standard-gid /var/log/openerp openerp openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/iu-CA.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/oc-FR.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/ml-IN.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/sr openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/web/static/lib/datejs/globalization/ab-RU.js openerp7.noarch: E: zero-length /usr/lib/python2.7/site-packages/openerp/addons/crm/wizard/crm_phonecall_to_opportunity.py openerp7.noarch: W: log-files-without-logrotate /var/log/openerp openerp7.noarch: W: no-manual-page-for-binary openerp-gen-cert openerp7-httpd-fonts-access.noarch: W: spelling-error %description -l en_US usr -> use, us, user openerp7-httpd-fonts-access.noarch: W: no-documentation openerp7-httpd-fonts-access.noarch: W: non-conffile-in-etc /etc/httpd/conf.d/fonts-access.conf Use %config(noreplace) /etc/httpd/conf.d/fonts-access.conf 3 packages and 0 specfiles checked; 14 errors, 11 warnings. For the rest i need to check my brain how we can solve those errors and warnings, i will let you know tomorrow or the next days. [ ]: Package does not own files or directories owned by other packages. Seems all directories seems to ne owned by the old package wich you want to replace. right? see attachment. Ok we should work on this points before final review. Created attachment 796132 [details]
licensecheck
Created attachment 796135 [details]
own-directories
(In reply to Wolfgang Ulbrich from comment #8) > > > You should add LGPLv2+ to licence field, see attachment > > rpmlint.txt As stated in LICENSING-BREAKDOWN, I have promoted all LGPLv2 file to GPLv3. It's messy enough... [cut] > Use %config(noreplace) /etc/httpd/conf.d/fonts-access.conf > > 3 packages and 0 specfiles checked; 14 errors, 11 warnings. > > For the rest i need to check my brain how we can solve those errors and > warnings, i will let you know tomorrow or the next days. You didn't miss my comments on these in comment #2? > [ ]: Package does not own files or directories owned by other packages. > Seems all directories seems to ne owned by the old package wich you want to > replace. right? > see attachment. Right. That's why I Conflict: it. Although Conflict: generally is frowned upon, I believe this use is legitimate. That's not to say I'm sure. Created attachment 915764 [details]
Comment
(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).
Many thanks for this review, it was really needed! --alec New Package SCM Request ======================= Package Name: openerp7 Short Description: Business Applications Server, version 7 line Owners: leamas Branches: f18 f19 f20 InitialCC: Git done (by process-git-requests). openerp7-7.0-1.20130618_231044.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openerp7-7.0-1.20130618_231044.fc20 Package openerp7-7.0-1.20130618_231044.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing openerp7-7.0-1.20130618_231044.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-20458/openerp7-7.0-1.20130618_231044.fc20 then log in and leave karma (feedback). openerp7-7.0-3.20140109_002644.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openerp7-7.0-3.20140109_002644.fc20 openerp7-7.0-4.20140109_002644.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/openerp7-7.0-4.20140109_002644.fc20 openerp7-7.0-4.20140109_002644.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. jgrulich's scratch build of kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 for f22-candidate and git://pkgs.fedoraproject.org/kdevelop?#c8e2b9bc57f11e41f3dc6612cdbcc591078d9062 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11212117 |