Bug 957436
| Summary: | Review Request: lookat - A user-friendly text file viewer | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christopher Meng <i> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lookat-1.4.2-1.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-23 12:33:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christopher Meng
2013-04-28 07:09:17 UTC
Ok, here we go:
1. Summary -- you don't have to capitalize every word; in fact, you shouldn't. Change it to something like "A user-friendly text file viewer".
2. %description -- substitute "lookat" with %{name}.
3. Build-time dependencies:
- glibc-devel is not used at all, remove it,
- the same applies to libtool,
- and pkgconfig too.
4. License -- FSF address stated in COPYING and all of the source files (*.[ch]) is outdated. Please, ask upstream to fix this in the next release. The current license is available here:
https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
5. Upstream build scripts don't provide support for aarch64. Please, run 'autoreconf -fiv' in the beginning of your %build section (or in %prep if you prefer) to fix this.
6. There's no need to define prefix, sysconfdir, or mandir. Just call plain '%configure' and watch the magic happen.
(In reply to comment #2) > 1. Summary -- you don't have to capitalize every word; in fact, you > shouldn't. Change it to something like "A user-friendly text file viewer". This is a copy and paste error, fixed. > 2. %description -- substitute "lookat" with %{name}. Well I never do this in my packages' %description section, I think it's a bit ugly... Is it a MUST or SHOULD? > 3. Build-time dependencies: > - glibc-devel is not used at all, remove it, > - the same applies to libtool, > - and pkgconfig too. Fixed. > 4. License -- FSF address stated in COPYING and all of the source files > (*.[ch]) is outdated. Please, ask upstream to fix this in the next release. > The current license is available here: > https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt Waiting upstream. > 5. Upstream build scripts don't provide support for aarch64. Please, run > 'autoreconf -fiv' in the beginning of your %build section (or in %prep if > you prefer) to fix this. Fixed, but there are no docs around currently. Where can I get detailed information to prevent things happen again? > 6. There's no need to define prefix, sysconfdir, or mandir. Just call plain > '%configure' and watch the magic happen. Fixed. (In reply to comment #3) > (In reply to comment #2) > > 1. Summary -- you don't have to capitalize every word; in fact, you > > shouldn't. Change it to something like "A user-friendly text file viewer". > > This is a copy and paste error, fixed. Ack. > > 2. %description -- substitute "lookat" with %{name}. > > Well I never do this in my packages' %description section, I think it's a > bit ugly... > > Is it a MUST or SHOULD? There's no hard rule for this but it's commonly discouraged to repeat the package name in summary and description. Using %{name} there is pretty much a matter of style. If you really don't want it, the don't change anything. Not a blocker. > > 3. Build-time dependencies: > > - glibc-devel is not used at all, remove it, > > - the same applies to libtool, > > - and pkgconfig too. > > Fixed. Ack. > > 4. License -- FSF address stated in COPYING and all of the source files > > (*.[ch]) is outdated. Please, ask upstream to fix this in the next release. > > The current license is available here: > > https://www.gnu.org/licenses/old-licenses/gpl-2.0.txt > > Waiting upstream. Ok. Not a blocker. > > 5. Upstream build scripts don't provide support for aarch64. Please, run > > 'autoreconf -fiv' in the beginning of your %build section (or in %prep if > > you prefer) to fix this. > > Fixed, but there are no docs around currently. Where can I get detailed > information to prevent things happen again? There are no guidelines for this yet, I believe, however this was discussed on Fedora development list in February and March this year. I'd give you links but lists.fedoraproject.org seems to be down at the moment. Briefly: check if the build files contain 'aarch64'; if they don't, they need to be regenerated with autoconf-2.69+ > > 6. There's no need to define prefix, sysconfdir, or mandir. Just call plain > > '%configure' and watch the magic happen. > > Fixed. Ack. --- Alright, approving. I also see Ken has sponsored you already (bug #947071#11), hence I'm removing the NEEDSPONSOR depedency. Please, do that in the rest of your reviews. You may now submit the SCM request. New Package SCM Request ======================= Package Name: lookat Short Description: A user-friendly text file viewer Owners: cicku Branches: f18 f19 InitialCC: Git done (by process-git-requests). lookat-1.4.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/lookat-1.4.2-1.fc18 lookat-1.4.2-1.fc18 has been pushed to the Fedora 18 testing repository. lookat-1.4.2-1.fc18 has been pushed to the Fedora 18 stable repository. |