Bug 957568

This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=5311136

%build
# Remove CFLAGS=... for noarch packages (unneeded)
CFLAGS="%{optflags}" %{__python} setup.py build

Your package is noarch, so the CFLAGS statement is unneeded, as the spec template says.


%files
...
/usr/bin/pc_query
/usr/bin/pycard-import
/usr/bin/pycardsyncer

Use macros instead of hardcoded paths:
%{_bindir}/pc_query
%{_bindir}/pycard-import
%{_bindir}/pycardsyncer


Please remove the upstream provided egginfo so that it gets rebuilt. See the packaging guidelines:
http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs


Your packages doesn't ship documentation. Add README.rst as %doc.


The source rpm is not built from the spec file provided by you. The %changelog is empty.

(In reply to comment #2)
> 
> Your packages doesn't ship documentation. Add README.rst as %doc.

Sorry for the blurb. The README files are already included in %doc.

The issues you noted have been fixed, new urls: 
Spec URL: http://puiterwijk.fedorapeople.org/python-carddav.spec
SRPM URL: http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-1.fc18.src.rpm

Scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5327305


$ rpmlint -i -v *
python-carddav.src: I: checking
python-carddav.src: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

python-carddav.src: I: checking-url http://lostpackets.de/pycarddav/ (timeout 10 seconds)
python-carddav.src: I: checking-url http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10 seconds)
python-carddav.noarch: I: checking
python-carddav.noarch: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

python-carddav.noarch: I: checking-url http://lostpackets.de/pycarddav/ (timeout 10 seconds)
python-carddav.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pycarddav/carddav.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carddav.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pycarddav/model.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carddav.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pycarddav/backend.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carddav.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pycarddav/__init__.py 0644L /usr/bin/python
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carddav.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pycarddav/controllers.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carddav.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/pycarddav/ui.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-carddav.noarch: W: no-manual-page-for-binary pycard-import
Each executable in standard binary directories should have a man page.

python-carddav.noarch: W: no-manual-page-for-binary pycardsyncer
Each executable in standard binary directories should have a man page.

python-carddav.noarch: W: no-manual-page-for-binary pc_query
Each executable in standard binary directories should have a man page.

python-carddav.spec: I: checking-url http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 8 errors, 3 warnings.


The changelog tag in the srpm's spec file is still empty. Please make sure you are using the right spec file to build the srpm. When you run "rpmbuild -bs" it could happen that it uses the backup spec (created by your text editor) instead of the new one. Remove any backups before.

Remove the shebangs from the mentioned files. Python scripts in %{python_sitelib}/ don't need a shebang at all.

Sorry, the SRPM url should have been http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-2.fc18.src.rpm
I will create a new one with removed shebangs.

Shebangs have been patched out:
Spec URL: http://puiterwijk.fedorapeople.org/python-carddav.spec
SRPM URL: http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-2.fc18.src.rpm

Some more issues:

cp pycard.conf.sample %{buildroot}%{_sysconfdir}/pycard.conf.sample

Either mark it as a config file by prepending %config(noreplace), or place it in %doc. Normally, users will create their own config files, that's why it would be sufficient to have it in %doc. I'm in doubt if it would work out-of-the-box as a config file due to the *.sample file extension.

"Source:" should be "Source0:" independent from the actual count of source files.

pycard.conf.sample has been moved to %doc, thanks for pointing that out.

Regarding Source: vs Source0:, this is just kind of personal style as far as I know. Although, if you can link me to any page saying I am required to do Source0, please link them to me, and I will change accordingly.


Spec URL: http://puiterwijk.fedorapeople.org/python-carddav.spec
SRPM URL: http://puiterwijk.fedorapeople.org/python-carddav-0.4.1-2.fc18.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5332335

$ rpmlint -i -v *
python-carddav.src: I: checking
python-carddav.src: I: checking-url http://lostpackets.de/pycarddav/ (timeout 10 seconds)
python-carddav.src: I: checking-url http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10 seconds)
python-carddav.noarch: I: checking
python-carddav.noarch: I: checking-url http://lostpackets.de/pycarddav/ (timeout 10 seconds)
python-carddav.noarch: W: no-manual-page-for-binary pycard-import
Each executable in standard binary directories should have a man page.

python-carddav.noarch: W: no-manual-page-for-binary pycardsyncer
Each executable in standard binary directories should have a man page.

python-carddav.noarch: W: no-manual-page-for-binary pc_query
Each executable in standard binary directories should have a man page.

python-carddav.spec: I: checking-url http://lostpackets.de/pycarddav/downloads/pyCardDAV-0.4.1.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

Nothing of interest.


---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
    MIT
[+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    $ sha256sum *
    460106dfbafb7ab47b41fb9be91b2c5be3cc9f2ce6543fa73af4943e8c89ad35  pyCardDAV-0.4.1.tar.gz
    460106dfbafb7ab47b41fb9be91b2c5be3cc9f2ce6543fa73af4943e8c89ad35  pyCardDAV-0.4.1.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.

----------------

PACKAGE APPROVED

----------------

New Package SCM Request
=======================
Package Name: python-carddav
Short Description: Python CardDAV client compatible with mutt
Owners: puiterwijk
Branches: f18 f19
InitialCC:

Git done (by process-git-requests).

python-carddav-0.4.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-carddav-0.4.1-2.fc19

python-carddav-0.4.1-2.fc19 has been pushed to the Fedora 19 stable repository.