Bug 957886

Summary: Bugs in addheader, getsymval
Product: [Fedora] Fedora Reporter: Chris Adams <linux>
Component: perl-Sendmail-PMilterAssignee: Paul Howarth <paul>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: paul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-Sendmail-PMilter-1.00-7.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-05-17 22:18:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix addheader, getsymval bugs none

Description Chris Adams 2013-04-29 19:35:21 UTC
Created attachment 741645 [details]
Fix addheader, getsymval bugs

I found a couple of bugs in the Sendmail-PMilter module.  It doesn't look like it is getting any updates upstream (and I'm not really up for taking it over at CPAN myself), so I thought I'd at least submit a patch for Fedora (since there are a couple of other patches in the Fedora RPM already).  They're simple bugs:

- addheader can't handle a header value of "0" (e.g. a spam score)
- getsymval doesn't search all the macro fields (probably should just merge the macros but I took the quick-and-easy path)

Also, it would be nice if this package was in EPEL as well.

Comment 1 Paul Howarth 2013-04-30 11:18:40 UTC
Patch looks sane enough but could you at least report it upstream so I can reference the ticket number and it can get incorporated if someone eventually steps up to maintain it?

Do you need it just for EL-6 or do you want EL-5 too?

Comment 2 Chris Adams 2013-04-30 14:42:31 UTC
Sure, I have opened CPAN bug 84941 (https://rt.cpan.org/Public/Bug/Display.html?id=84941).

The server I'd like to use this on is still running CentOS 5 (want to upgrade to 6 but haven't had the time), so EL-5 would be nice.

Thanks.

Comment 3 Paul Howarth 2013-04-30 15:37:13 UTC
Do you actually need this in Fedora 18? If not, I'll just update F-19, Rawhide and do the two EPEL builds.

Comment 4 Chris Adams 2013-04-30 15:41:25 UTC
No, I was developing a milter on Fedora 18, but the "production" target is CentOS 5.

Comment 5 Paul Howarth 2013-04-30 15:54:01 UTC
OK, I'll not do an F-18 update then.

Comment 6 Fedora Update System 2013-04-30 16:52:01 UTC
perl-Sendmail-PMilter-1.00-7.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Sendmail-PMilter-1.00-7.fc19

Comment 7 Fedora Update System 2013-04-30 16:58:21 UTC
perl-Sendmail-PMilter-1.00-7.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/perl-Sendmail-PMilter-1.00-7.el5

Comment 8 Fedora Update System 2013-04-30 16:58:35 UTC
perl-Sendmail-PMilter-1.00-7.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Sendmail-PMilter-1.00-7.el6

Comment 9 Fedora Update System 2013-05-01 19:23:04 UTC
perl-Sendmail-PMilter-1.00-7.el5 has been pushed to the Fedora EPEL 5 testing repository.

Comment 10 Fedora Update System 2013-05-05 03:25:12 UTC
perl-Sendmail-PMilter-1.00-7.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2013-05-17 22:18:18 UTC
perl-Sendmail-PMilter-1.00-7.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 12 Fedora Update System 2013-05-17 22:20:26 UTC
perl-Sendmail-PMilter-1.00-7.el5 has been pushed to the Fedora EPEL 5 stable repository.